Merge pull request #137 from dstansby/bg-overwrite

Prevent bg being modified in place
dstansby · Jan 3, 2020 · 7bf681d · 7bf681d
1 parent 53cce31
commit 7bf681d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/doc/source/changes.rst b/doc/source/changes.rst
@@ -1,6 +1,12 @@
 Changelog
 =========
 
+0.4.2
+-----
+
+- Fix a bug where :class`pfsspy.tracing.FotranTracer` would overwrite the
+  magnetic field values in an :class:`~pfsspy.Output` each time it was used.
+
 0.4.1
 -----
 

diff --git a/pfsspy/__init__.py b/pfsspy/__init__.py
@@ -362,7 +362,9 @@ def bg(self):
             bpg[i, :, :] /= (Sbp[:-1, :-1] + Sbp[1:, :-1] +
                              Sbp[1:, 1:] + Sbp[:-1, 1:])
         bsg *= -1
-        return np.stack((bpg, bsg, brg), axis=-1)
+        out = np.stack((bpg, bsg, brg), axis=-1)
+        out.flags.writeable = False
+        return out
 
     def _common_b(self):
         """

diff --git a/pfsspy/tracing.py b/pfsspy/tracing.py
@@ -78,7 +78,7 @@ def trace(self, seeds, output):
         self.validate_seeds_shape(seeds)
 
         # The indexing order on the last index is (phi, s, r)
-        vectors = output.bg
+        vectors = output.bg.copy()
 
         # Correct s direction for coordinate system distortion
         sqrtsg = output.grid._sqrtsg_correction