Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from 0.2.6 to 0.2.7 installs test dependencies #8

Open
ashokdelphia opened this issue Jul 12, 2020 · 1 comment · May be fixed by #10
Open

Upgrading from 0.2.6 to 0.2.7 installs test dependencies #8

ashokdelphia opened this issue Jul 12, 2020 · 1 comment · May be fixed by #10

Comments

@ashokdelphia
Copy link
Contributor

If I upgrade using poetry with poetry update --lock pprp, I get nose and coverage installed as non-dev dependencies.

In a vanilla Python 3.7 virtualenv:

$ pip -q install pprp
$ pip freeze
coverage==5.2
nose==1.3.7
pprp==0.2.7

Is that expected behaviour?

I would expect them only to be test dependencies for the project itself, not pulled in for downstream projects that use pprp.

I think the change came as part of 90b3d0c, but I'm not very familiar with setup.py and packaging python libraries, so can't easily offer a code change to fix it.

@arthurdarcet
Copy link

As far as I can see, the 0.2.7 update killed the py3 code, and kept the py2 version… We'll stick with 0.2.6 for now here

ashokdelphia added a commit to ashokdelphia/RijndaelPbkdf that referenced this issue Sep 11, 2020
I'm fairly new to python packaging, so I'm not sure if this is the best way to solve this.

Fixes dsoprea#8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants