-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropbboxClient Upload closes Stream #340
Labels
Comments
Thanks for writing this up! I'll ask the team to look into changing this behavior and offer options for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When calling a DropboxClient to upload a file via a stream, the function has the side effect of closing the stream:
What happens:
dropbboxClient.Files.UploadAsync closes the stream after upload.
What should happen:
dropbboxClient.Files.UploadAsync should not close the stream. This is a hidden side effect that shouldn't happen.
Temporary Workaround:
Copy the stream into another stream.
AWS has some nice convenience features parallel to this with their s3 SDK.
The default of the sdk should be to NOT close the stream as this is a hidden side effect. However a nice enhancement would be to provide convenience properties in the class UploadArg of "AutoCloseStream" and "AutoResetStreamPosition" which can be set.
Thank you for reviewing.
The text was updated successfully, but these errors were encountered: