Skip to content

Content prompt for deleting the number of files in the folder #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
yu2chuan opened this issue Mar 9, 2025 · 7 comments
Open
1 task

Content prompt for deleting the number of files in the folder #813

yu2chuan opened this issue Mar 9, 2025 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@yu2chuan
Copy link

yu2chuan commented Mar 9, 2025

Describe the bug
When deleting a folder in the markflowy, a confirmation is needed.

To Reproduce

Desktop (please complete the following information):

  • OS: Win10
  • Version 0.19

Additional context

Other

  • I want to try to fix this issue.
@yu2chuan yu2chuan added the status: needs triage This issue needs to triage, applied to new issues label Mar 9, 2025
@drl990114
Copy link
Owner

Are you saying that you haven't seen a pop-up window confirming the deletion so far

@yu2chuan
Copy link
Author

yu2chuan commented Mar 9, 2025

a pop-up window confirms the deletion.
but, my suggestion

  1. if there is the other files in this folder, this folder including not markdown files will be deleted.
  2. if all files are md file in this folder, this folder including 7 markdown file will be deleted.

@drl990114
Copy link
Owner

drl990114 commented Mar 10, 2025

Sorry, I still haven't figured out what your expected outcome is? I haven't confirmed the pop-up window or deleted the contents of the folder cleanly?

Under normal circumstances, this is the way it behaves. Click on 'Delete Folder' -> a pop-up prompt prompts for confirmation
-> after confirmation, delete all files in the folder

@yu2chuan
Copy link
Author

If users manage the files with Markflowy UI, users can only see md file but other files like docx in the same folder. Users could accidently delete this docx file when deleting the folder.
If markflowy detects not-md file in the same folder, the message should confirm users that there are not md files in this folder will be deleted together.

@drl990114
Copy link
Owner

I understand, I'll think about it again. I don't know if displaying all the files in the folder is a good choice?

@yu2chuan
Copy link
Author

If the program detects some xls, pdf files in the folder user will delete, the message can be "xls, pdf, etc in the same folder will also be deleted. Confirm deletion?

@drl990114
Copy link
Owner

This is also good, it should be a good optimization for interaction

@drl990114 drl990114 added enhancement New feature or request and removed status: needs triage This issue needs to triage, applied to new issues labels Mar 19, 2025
@drl990114 drl990114 changed the title a bug for deleting folders Content prompt for deleting the number of files in the folder Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants