Merge pull request firemodels#2217 from gforney/master

gforney · web-flow · commit 1e9d4212543f · 2025-03-09T23:21:49.000-04:00
fix memory overwrite error (loop used i instead of ii for loop index)
diff --git a/Source/smokeview/readsmv.c b/Source/smokeview/readsmv.c
@@ -10341,7 +10341,7 @@ typedef struct {
                 hidden6, hidden6 + 1, hidden6 + 2, hidden6 + 3, hidden6 + 4, hidden6 + 5);
               int ii;
               for(ii = 0; ii < 6; ii++){
-                if(hidden6[i] >= 0)hidden6[ii] = 1 - hidden6[ii];
+                if(hidden6[ii] >= 0)hidden6[ii] = 1 - hidden6[ii];
               }
               memcpy(bc->hidden6, hidden6, 6*sizeof(int));
               if(hidden6[0] >= 0)scase->have_hidden6 = 1;

Original file line number	Diff line number	Diff line change
`@@ -10341,7 +10341,7 @@ typedef struct {`
`10341`	`10341`	`hidden6, hidden6 + 1, hidden6 + 2, hidden6 + 3, hidden6 + 4, hidden6 + 5);`
`10342`	`10342`	`int ii;`
`10343`	`10343`	`for(ii = 0; ii < 6; ii++){`
`10344`		`- if(hidden6[i] >= 0)hidden6[ii] = 1 - hidden6[ii];`
	`10344`	`+ if(hidden6[ii] >= 0)hidden6[ii] = 1 - hidden6[ii];`
`10345`	`10345`	`}`
`10346`	`10346`	`memcpy(bc->hidden6, hidden6, 6*sizeof(int));`
`10347`	`10347`	`if(hidden6[0] >= 0)scase->have_hidden6 = 1;`