-
Notifications
You must be signed in to change notification settings - Fork 2.4k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in an opinionated pre-commit #188
Comments
I would also love to see this feature! Consider adding |
Hi guys, can I take this issue? What I have in mind is a pre-commit with the following plugin:
please, let me know your thoughts |
@fgriberi feel free to ping me for review / help 👍 |
I like the idea of this. A few additional thoughts:
Also, it is worth noting that the current project template is supposed to be VCS agnositic, so it almost makes more sense once #162 is in. (Which we are pushing right now to get CI working for, if anyone wants to look at #205 where @jayqi was exploring ways to test virtualenvwrapper on Windows). |
@pjbull I've been thinking about using pre-commit instead of a bash script. The integration with the mentioned tools is awesome. What do you think? |
I didn't find the increase in complexity to be worth it for our team, and I think that it sacrifices the flexibility that a project template like this should have. |
Hi everyone, I've created a pull request (#323) that addresses this issue. It adds pre-commit hooks for code formatting and linting to enhance code quality and consistency in the project. The pre-commit hooks include tools such as You can review the pull request here: Pull Request #323 Your feedback and suggestions are greatly appreciated. Please take a look at the changes, and if everything looks good, your approval would be fantastic. If you have any comments or questions, feel free to share them in the PR discussion. Let's work together to improve the code quality of this project! Thank you for your attention to this matter. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
I would like to propose adding in an opinionated
.pre-commit-config.yaml
, to enable pre-commit hooks in the project. Doing so would help push automated code checks directly to the local repo clone, and can help with ensuring code quality.In terms of whether or not this should be enabled by default, I would lean towards not enabling it by default, as the use of pre-commit is not commonly taught in introductory
git
courses. However, I am quite sure that seasonedgit
users will appreciate its availability in the repository nonetheless.Before I get working on it, was wondering what you all might think about this contribution? As this would be my first contribution to the repo, I am happy to follow your guidance on what else should be added.
The text was updated successfully, but these errors were encountered: