-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark pydantic integration (as an extra?) #385
Labels
good first issue
Good for newcomers
Comments
I'm kind of on the fence about the value of adding an extra here. Would it work for us just to add type ignore at that import line? We don't actually use any of the pydantic types. |
Let's go with the ignore fix here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We run mypy with
ignore_missing_imports = false
and then have an explicit allow list for packages. Sincecloudpathlib
imports pydantic (albeit behind a guard) but does not depends on it, mypy fails with :We would normally set
ignore_missing_imports
for justpydantic_core
, but that's somewhat wonky in this case becausepydantic_core
does have type stubs, it's just not a dependency.I think the most straightforward approach would be to add a pydantic extra to cloudpathlib, but there might be a fancier way to inform mypy directly of the "optional-ness" of the imports.
The text was updated successfully, but these errors were encountered: