Skip to content

Commit a8f0868

Browse files
committed
Update the pg-codemirror-editor to pull in a bugfix.
There is early termination code in the PGML parser that is not actually part of PGML. It is there to catch impartial constructs that occur while typeing. For instance, say you have already typed ``[` `]``, and then you start to type `[$` inside that. This code terminates the outer block so that syntax highlighting continues to work after the outer block. Unfortunately, it was also early terminating 'balance' blocks inside outer blocks even though those could contain the terminator of the outer block. This can cause tokens inside the block to be incorrectly terminated early. For example, in `[@ '[@ "inner code" @]' @]**` the single quote starts a 'balance' type block, and the `@]` inside the string tries to terminate the outer `[@` block. Of course that example isn't something you should do any, but this was seen in a more complicated construct than that example. That sort of thing is often needed for cases inside a BEGIN_PGML_SOLUTION/END_PGML_SOLUTION block.
1 parent d77931e commit a8f0868

File tree

2 files changed

+70
-76
lines changed

2 files changed

+70
-76
lines changed

htdocs/package-lock.json

Lines changed: 69 additions & 75 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

htdocs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"dependencies": {
1616
"@fortawesome/fontawesome-free": "^6.5.2",
17-
"@openwebwork/pg-codemirror-editor": "^0.0.1-beta.28",
17+
"@openwebwork/pg-codemirror-editor": "^0.0.1-beta.29",
1818
"bootstrap": "~5.3.3",
1919
"flatpickr": "^4.6.13",
2020
"iframe-resizer": "^4.3.11",

0 commit comments

Comments
 (0)