-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Was able to publish a patch without requesting a review first. #62
Comments
This should have prevented you from doing this as that patch had never had a review requested. There must a bug with the enforcement of that rule or something. But that is the intended behavior and the |
@RyanHedges I just tested this on my machine with a recent patch and it worked correctly. What version of git-ps are you using? See output from command line with my test.
|
@drewdeponte |
@RyanHedges so are you saying the behavior is inconsistent? |
@drewdeponte Yes, the behavior appears to be inconsistent. |
I was able to
pub
a patch without it having an obvious corresponding review.I had two patches, where patch id 1 had a review requested. I meant to publish 1 but typed 0 accidentally. the below output was done after performing a
pull
and a newrr 1
. In the output below you'll see agps
which is my alias forgit-ps
command. I'm onv1.1.1
. I did a couple test on a clean repo and I haven't been able to reproduce. making two commits and trying topub
one that doesn't have a requested review fails to publish as expected. I'm unsure of the commands ran before this happened but I'm sure there were rebases, pulls, and publishing of other patches.Console output
The text was updated successfully, but these errors were encountered: