Skip to content

Commit 81a4de7

Browse files
committed
small bug fixes after Linux testing
1 parent 0469d75 commit 81a4de7

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Minimalist stand-alone XRechnung generator
55

66
## Outline
77

8-
When it comes to [**open-source**](https://opensource.org/osd) and [**stand-alone applications**](https://en.wikipedia.org/wiki/Standalone_software) capable of creating **XML electronic invoices**, there are not many options to chose from. **XFakturist** strives to be one of them, while focussing on simple invoices with a small number of invoice items. While **XFakturist** is a minimalist tool to issue electronic invoices, it features the embedding of invoice attachments, like PDF documents, in the XML data. As a command-line application with incomplete documentation, **XFakturist** will likely only appeal to the technically savvy computer user.
8+
When it comes to [**open-source**](https://opensource.org/osd) and [**stand-alone applications**](https://en.wikipedia.org/wiki/Standalone_software) capable of creating **XML electronic invoices**, there are not many options to chose from. **XFakturist** strives to be one of them, focussing on simple invoices with a small number of invoice items. While **XFakturist** is a minimalist tool to issue electronic invoices, it features the embedding of invoice attachments, like PDF documents, in the XML data. As a command-line application with incomplete documentation, **XFakturist** will likely only appeal to the technically savvy computer user.
99

1010

1111
## Features
@@ -65,6 +65,7 @@ _Currently, only macOS and Linux systems are supported. MS Windows might also wo
6565
Python (version 3.10 or later) must be installed on your system, for example, a current [Anaconda distribution](https://www.anaconda.com/download). Among the required Python packages, we highlight the following ones, which might require upgrading your Python installation:
6666
```
6767
json5
68+
openpyxl
6869
xmltodict
6970
```
7071
XML electronic invoice creation using command `xr-compile` does only depend on the availability of such a Python installation on your computer. Download and unpack the **XFakturist** ZIP-file or clone the **XFakturist** Github repository. Make sure that Python script `xr-compile` is in your search path.

compiler/xrechnung.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ def _process_node(self, target: dict | list, key: str, source: dict) -> list:
232232
recursion_depths = self._process_dict(val, source)
233233
if (
234234
recursion_depths == [("cbc:ID", False, 3)]
235+
or target[key] == {}
235236
or pd.Series(target[key].keys()).str.match(r"^@[A-Za-z]+$").all()
236237
):
237238
# remove sub-dictionary `target[key]` if,
@@ -370,11 +371,11 @@ def read_excel(self, workbook_file: Path):
370371
attachment.read()
371372
).decode("utf-8")
372373
self._logger.info(
373-
f" > embedding file '{column_dict["fakturist:Filename"]}'"
374+
f" > embedding file {column_dict['fakturist:Filename']}"
374375
)
375376
else:
376377
self._logger.info(
377-
f" > column skipped, file '{column_dict["fakturist:Filename"]}' not found"
378+
f" > column skipped, file {column_dict['fakturist:Filename']} not found"
378379
)
379380
continue
380381

get-kosit-xr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/sh
1+
#!/usr/bin/env bash
22

33
# Copyright 2024 - present Dr Tim Brunne (Munich)
44
#

xr-convert

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/sh
1+
#!/usr/bin/env bash
22

33
# Copyright 2024 - present Dr Tim Brunne (Munich)
44
#

xr-validate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/sh
1+
#!/usr/bin/env bash
22

33
# Copyright 2024 - present Dr Tim Brunne (Munich)
44
#

0 commit comments

Comments
 (0)