Skip to content

Allow including Content-MD5 in S3 object uploads #2094

@rpadaki

Description

@rpadaki

Is your feature request related to a problem? Please describe.

This is required to use SFTP-Go with Object Lock enabled buckets. You just need to compute the hash and include in each put object or upload part call: https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-managing.html#object-lock-put-object

Describe the solution you'd like

In s3fs.go, in the singlePartUpload and uploadPart methods, we should add md5 calculation logic. To prevent any regressions, I think this should be opt-in via a boolean option, which requires some frontend changes. Additionally, we'd need to update the config type in https://github.com/sftpgo/sdk.

Describe alternatives you've considered

No response

What are you using SFTPGo for?

Medium business

Additional context

I actually sketched out most of the required code changes locally and would be happy to open a PR if I can get confirmation that the above approach looks right.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions