Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory defragmentation improvements #2979

Closed
romange opened this issue Apr 30, 2024 · 2 comments
Closed

memory defragmentation improvements #2979

romange opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@romange
Copy link
Collaborator

romange commented Apr 30, 2024

  1. Currently our defragmentation procedure is fully automatic but can sometimes miss important cases.
    We should add "MEMORY DEFRAGMENT" that will force kicking off the defragmentation process on all the data shards.
  2. In addition, the defragmentation is triggered based on "used memory/max memoryt" threshold which is not accurate. Some workloads may have "used" part below the threshold and still have high RSS usage with high fragmentation rates for the data. We can not just call ReadShardMemUsage without preliminary cheaper checks. Therefore I suggest replacing the "used" check with RSS check, i.e when the RSS /maxmemory is high - to check the fragmentation stats. Finally, even in this case we may find ourselves calling ReadShardMemUsage too much. We should make sure we do not call it more often then once in K seconds.
@romange romange added the enhancement New feature or request label Apr 30, 2024
@romange romange added this to the v1.18 milestone May 2, 2024
@romange romange assigned BorysTheDev and unassigned adiholden May 2, 2024
@romange
Copy link
Collaborator Author

romange commented May 2, 2024

for (2) I am talking about mem_defrag_threshold flag

@romange
Copy link
Collaborator Author

romange commented May 2, 2024

for (1) to kick-off DoDefrag process manually without checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants