Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check_live_ram): increase /run tmpfs size if needed #2551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(check_live_ram): increase /run tmpfs size if needed #2551

wants to merge 1 commit into from

Conversation

FGrose
Copy link
Contributor

@FGrose FGrose commented Nov 8, 2023 •
edited 

fix(check_live_ram): increase /run tmpfs size, if needed

Check the size and available space in /run to enlarge it,
  if needed.
Introduce the check_meminfo() function to dracut-lib.sh
  to replace a less versatile sed call.
Also, use local variables,
  use parameter expansion to assign a default value,
  use test exit logic directly, where possible,
  tweak comments,
  and move the check_live_ram() function to img-lib.sh.

Checklist

  • [✔] I have tested it locally

Fixes #2550

@github-actions github-actions bot added modules Issue tracker for all modules base Issues related to the base module labels Nov 8, 2023
@LaszloGombos
Copy link
Collaborator

This looks good to me.

@FGrose what do you think about moving check_live_ram (and check_meminfo) to img-lib.sh instead of the catch-all dracut-lib.sh ?

@github-actions github-actions bot added the img-lib Issues related to the img-lib module label Dec 3, 2023
@FGrose
fix(check_live_ram): increase /run tmpfs size, if needed
bc76f15 
Check the size and available space in /run to enlarge it,
  if needed.
Introduce the check_meminfo() function to dracut-lib.sh
  to replace a less versatile sed call.
Also, use local variables,
  use parameter expansion to assign a default value,
  use test exit logic directly, where possible,
  tweak comments,
  and move the check_live_ram() function to img-lib.sh.
@stale Stale
Copy link

stale bot commented Mar 13, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Mar 13, 2024
@cbs228
Copy link

cbs228 commented Mar 13, 2024

This PR is needed for #2550 and is still waiting on review.

@stale stale bot removed the stale communication is stuck label Mar 13, 2024
@LaszloGombos LaszloGombos added this to the dracut-060 milestone Mar 14, 2024
@LaszloGombos LaszloGombos added the bug Our bugs label Mar 14, 2024
@LaszloGombos LaszloGombos removed this from the dracut-060 milestone Mar 14, 2024
@Athwale
Copy link

Athwale commented Mar 29, 2024

Any progress on this please, can someone review this and approve it? I am hitting this problem on f39.
Thanks.

@Conan-Kudo
Copy link
Member

I approved it, but I haven't had merge permissions for a while. ☹️

@Athwale
Copy link

Athwale commented Mar 29, 2024

@haraldh @johannbg @tblume Can you please have a look at this? Thank you.

@LaszloGombos LaszloGombos mentioned this pull request Mar 30, 2024
Merged
@Athwale
Copy link

Athwale commented Apr 6, 2024

This is a related issue also connected to the low /run size
#2550
Particularly the rd.writable.fsimg=1 copies rootfs.img into RAM and this image is typically even larger than the squashfs.img.

@LaszloGombos LaszloGombos mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

@LaszloGombos LaszloGombos LaszloGombos approved these changes

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

@johannbg johannbg Awaiting requested review from johannbg johannbg is a code owner

@tblume tblume Awaiting requested review from tblume

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
base Issues related to the base module bug Our bugs img-lib Issues related to the img-lib module modules Issue tracker for all modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rd.live.ram=1 may fill up /run if tmpfs is too small
5 participants
@FGrose @LaszloGombos @cbs228 @Athwale @Conan-Kudo