Many shellcheck complains

[bdrung]

Running make syncheck on Ubuntu 24.04 on the source code shows a lot of shellcheck complains, including:

• SC2086 (info): Double quote to prevent globbing and word splitting.
• SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

Remaining output after disabling those two:

$ make syncheck
shellcheck $(shfmt -f .)

In dracut.sh line 1382:
        && dracut_args[$i]="\"${dracut_args[$i]}\""
                       ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables.


In modules.d/80lvmthinpool-monitor/start-thinpool-monitor.sh line 12:
    [ -n "$_lvm2_thin_device" ] && return $?
                                          ^-- SC2319 (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.


In modules.d/95iscsi/iscsiroot.sh line 232:
    [ -z "$targets" ] && warn "Target discovery to $iscsi_target_ip:${iscsi_target_port:+$iscsi_target_port} failed with status $?" && return 1
                                                                                                                                ^-- SC2319 (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.

For more information:
  https://www.shellcheck.net/wiki/SC2319 -- This $? refers to a condition, no...
  https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...
make: *** [Makefile:239: syncheck] Fehler 1

[LaszloGombos]

Thanks @bdrung . Somewhat expected, but good to have a bug for it.
CC @jamacku

[bdrung]

Do we run shellcheck on the CI?

[LaszloGombos]

Do we run shellcheck on the CI?

Yes we do. #75 . Only differential. And some warnings are disabled - https://github.com/dracut-ng/dracut-ng/blob/main/.shellcheckrc

[jamacku]

This is somewhat expected. make syncheck calls regular shellcheck, but upstream uses a GitHub workflow that runs differential scans of ShellCheck and reports only newly added defects caused by changes from PR or commit.

Once a PR is merged, defects are considered false positives since they went through review. However, maintainers have access to all defects in the Security tab in the GitHub UI.

• https://github.com/dracut-ng/dracut-ng/actions/runs/9176735579

I'm currently working on making differential ShellCheck available as CLI and possibly packaged in distributions (redhat-plumbers-in-action/differential-shellcheck#179, redhat-plumbers-in-action/differential-shellcheck#396). Then you could use it in make syncheck as well.

[bdrung]

I submitted a bunch of merge requests to address shellcheck complains. Current status: after applying all my open merge requests, there are five SC2086 plus a all (a lot) SC2317 complains left. I'll address the remaining SC2086 soon. Then only SC2317 will be left. So make syncheck could be run on all merge requests then.

[bdrung]

I submitted some more merge requests to address shellcheck complains. Current status: Only four SC2317 complains left.

[bdrung]

All shellcheck complains are fixed now. make syncheck is happy on the current main branch (commit cc5e8d6).