From 304c56b2a920d96c5facd0eeb0d8bf98e36841ee Mon Sep 17 00:00:00 2001 From: Joe Heck Date: Mon, 21 Dec 2015 08:40:35 -0800 Subject: [PATCH] rationalizing logs updating mapping to more constricted set of logs per https://github.com/RackHD/RackHD/issues/34 **NOTE**: Requires https://github.com/RackHD/on-core/pull/48 to be committed prior as it adds the synonym 'critical' to the existing 'crit' level. --- index.js | 2 +- lib/message-handler.js | 4 ++-- lib/parser.js | 2 +- lib/server.js | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/index.js b/index.js index 5003a3c..3cedde0 100644 --- a/index.js +++ b/index.js @@ -29,7 +29,7 @@ core.start() ).start(); }) .catch(function(e) { - logger.error("Error starting server", { + logger.critical("Error starting server", { error: e }); process.nextTick(function() { diff --git a/lib/message-handler.js b/lib/message-handler.js index 126ced1..81db4ec 100644 --- a/lib/message-handler.js +++ b/lib/message-handler.js @@ -61,7 +61,7 @@ function messageHandlerFactory( } }) .catch(function(err) { - logger.error("Failed to get bootfile information for " + packetData.chaddr.address, { + logger.warning("Failed to get bootfile information for " + packetData.chaddr.address, { error: err }); }); @@ -310,7 +310,7 @@ function messageHandlerFactory( if (action === 'discover') { assert.object(this.packetData); - logger.silly( + logger.debug( "Unknown node %s. Sending down default bootfile." .format(this.packetData.chaddr.address) ); diff --git a/lib/parser.js b/lib/parser.js index 7301b63..8d8fc11 100644 --- a/lib/parser.js +++ b/lib/parser.js @@ -328,7 +328,7 @@ function ParserFactory(protocol, Logger, assert) { } if (unhandledOptions.length) { - this.logger.silly('Unhandled DHCP options (' + + this.logger.debug('Unhandled DHCP options (' + unhandledOptions.map(function (option) { return option.code + ':' + option.len; }).join() + ')', { diff --git a/lib/server.js b/lib/server.js index 37e5651..77d6f5c 100644 --- a/lib/server.js +++ b/lib/server.js @@ -36,7 +36,7 @@ function serverFactory(core, messageHandler, Logger) { if (data.isefi === true) { currentOutport = this.outportEFI; } - logger.info('current OutPort => %d'.format(currentOutport)); + logger.debug('current OutPort => %d'.format(currentOutport)); this.server.send(packetBuffer, 0, packetBuffer.length, currentOutport, destination, sendCallback); }; @@ -49,7 +49,7 @@ function serverFactory(core, messageHandler, Logger) { }); self.server.on('error', function(err) { - logger.emerg("proxyDHCP server error: ", err); + logger.critical("proxyDHCP server error: ", err); process.nextTick(function() { process.exit(1); });