Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: path in bucket for s3 coordinator #224

Open
BorisTyshkevich opened this issue Feb 20, 2025 · 1 comment
Open

core: path in bucket for s3 coordinator #224

BorisTyshkevich opened this issue Feb 20, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@BorisTyshkevich
Copy link

Now, s3 coordinator creates directories in the root of the provided bucket.
It's not good when a bucket is used for something else.
It is better to have a parameter to specify a path or allow a path at the end of the bucket:

trcli replicate --coordinator s3 --coordinator-s3-bucket XXXX --coordinator-s3-path YYYY
trcli replicate --coordinator s3 --coordinator-s3-bucket XXXX/YYYY
@laskoviymishka laskoviymishka added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 21, 2025
@laskoviymishka
Copy link
Contributor

That's a good improvement.
Relatevely easy to implement, need to pass it here and handle there.

@laskoviymishka laskoviymishka changed the title path in bucket for s3 coordinator core: path in bucket for s3 coordinator Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants