-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 12830 multi target demo console #12996
base: main
Are you sure you want to change the base?
Issue 12830 multi target demo console #12996
Conversation
Drafted because:
|
@Tanya-Solyanik @LeafShi1 @Epica3055 I was able to get the I’m aware of the nullability warnings that I still need to address, but could they be related to this issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable all CLR exceptions before starting to debug this project as 4.8.1. I guess immutable collection reference is not discovered.
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/DemoConsole.csproj
Show resolved
Hide resolved
<TargetFramework /> | ||
|
||
<Nullable>enable</Nullable> | ||
<UseWindowsForms>true</UseWindowsForms> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are referencing project when building Core and you have assembly references when building NETFX, line 32 is not needed.
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/DemoConsole.csproj
Show resolved
Hide resolved
@@ -37,6 +40,7 @@ protected override void Dispose(bool disposing) | |||
base.Dispose(disposing); | |||
} | |||
|
|||
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change can be factored out into a separate PR with some other cleanup changes you have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is necessary to prevent the following build error, which occurs regardless of whether the solution is built from the root or the DemoConsole
folder:
"C:\Users\v-rbossan\source\repos\winforms\Winforms.sln" (default target) (1) ->
"C:\Users\v-rbossan\source\repos\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DemoConsole\DemoConsole.csproj" (default target) (42) ->
"C:\Users\v-rbossan\source\repos\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DemoConsole\DemoConsole.csproj" (Build target) (42:2) ->
"C:\Users\v-rbossan\source\repos\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj" (default target) (43:4) ->
(CoreCompile target) ->
C:\Users\v-rbossan\source\repos\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\PropertyGridExt.cs(43,26): error WFO1000: Property 'DesignerHost' does not configur
e the code serialization for its property content [C:\Users\v-rbossan\source\repos\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj::TargetFra
mework=net10.0-windows]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this change is necessary, I suggest getting it in before the rest of the changes in this PR to make this PR more targetted.
e1471f3
to
78c0cbd
Compare
Fixes #
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow