Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports DataMemberFieldEditor to the Runtime #12891

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Ports DataMemberFieldEditor to the Runtime #12891

merged 4 commits into from
Feb 14, 2025

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Feb 6, 2025 •
edited
Loading

Related #2339

Proposed changes

  • Ports DataMemberFieldEditor to the Runtime.
  • Adds scenario for WinformsControlsTest where this change is apparent

Customer Impact

  • Will add functionality to the DatamemberFieldEditor in the Runtime.

Risk

  • Minimal

Screenshots

Before

DemoConsole

before

WinformsControlsTest

before2

After

DemoConsole

after

WinformsControlsTest

after2

Test methodology

  • Manual

Test environment(s)

  • 10.0.100-alpha.1.25077.2
Microsoft Reviewers: Open in CodeFlow

@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Feb 6, 2025
@ricardobossan ricardobossan self-assigned this Feb 6, 2025
@ricardobossan ricardobossan requested a review from a team as a code owner February 6, 2025 22:49
Copilot
Copilot AI reviewed Feb 6, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@ricardobossan ricardobossan marked this pull request as draft February 6, 2025 22:57
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Feb 7, 2025
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 11, 2025
@ricardobossan ricardobossan marked this pull request as ready for review February 11, 2025 19:14
@ricardobossan ricardobossan added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author draft draft PR waiting-review This item is waiting on review by one or more members of team labels Feb 11, 2025
@ricardobossan ricardobossan marked this pull request as draft February 11, 2025 19:18
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.61538% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.97766%. Comparing base (dd64431) to head (d42d496).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12891         +/-   ##
===================================================
- Coverage   76.07869%   75.97766%   -0.10103%     
===================================================
  Files           3260        3265          +5     
  Lines         642402      643272        +870     
  Branches       47314       47426        +112     
===================================================
+ Hits          488731      488743         +12     
- Misses        150120      150965        +845     
- Partials        3551        3564         +13
Flag Coverage Δ
Debug 75.97766% <59.61538%> (-0.10103%) ⬇️
integration 18.00658% <0.00000%> (-0.06249%) ⬇️
production 49.87317% <30.00000%> (-0.15116%) ⬇️
test 96.95378% <100.00000%> (+0.00018%) ⬆️
unit 47.33829% <30.00000%> (-0.11071%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan ricardobossan marked this pull request as ready for review February 11, 2025 21:12
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Feb 11, 2025
Tanya-Solyanik
Tanya-Solyanik reviewed Feb 12, 2025
View reviewed changes
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 12, 2025
@ricardobossan ricardobossan marked this pull request as draft February 12, 2025 21:26
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Feb 12, 2025
@ricardobossan ricardobossan marked this pull request as ready for review February 13, 2025 00:28
@ricardobossan ricardobossan removed waiting-author-feedback The team requires more information from the author draft draft PR labels Feb 13, 2025
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Feb 13, 2025
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 13, 2025
@ricardobossan ricardobossan added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 13, 2025
@ricardobossan ricardobossan mentioned this pull request Feb 13, 2025
Open
73 tasks
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 14, 2025
Tanya-Solyanik
Tanya-Solyanik previously approved these changes Feb 14, 2025
View reviewed changes
Ports DataMemberFieldEditor to the Runtime
ccf03c1 
Related dotnet#1115

- Ports `DataMemberFieldEditor` to the Runtime.

- Will add functionality to the `DatamemberFieldEditor` in the Runtime.

- Minimal

- Manual

- `10.0.100-alpha.1.25077.2`
@ricardobossan ricardobossan force-pushed the Issue_1115_Port_DataMemberFieldEditor branch from 80f7ac7 to ccf03c1 Compare February 14, 2025 00:34
Tanya-Solyanik
Tanya-Solyanik previously approved these changes Feb 14, 2025
View reviewed changes
@ricardobossan ricardobossan enabled auto-merge (squash) February 14, 2025 00:37
@Tanya-Solyanik Tanya-Solyanik removed the waiting-author-feedback The team requires more information from the author label Feb 14, 2025
Tanya-Solyanik
Tanya-Solyanik previously approved these changes Feb 14, 2025
View reviewed changes
@ricardobossan ricardobossan merged commit 4de9ca9 into dotnet:main Feb 14, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview2 milestone Feb 14, 2025
@ricardobossan ricardobossan mentioned this pull request Feb 18, 2025
Merged
@chaowendy
Copy link
Contributor

Verified this PR in Winforms main branch for .NET10.0，DatamemberFieldEditor are supported in the runtime.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@LeafShi1 LeafShi1 Awaiting requested review from LeafShi1

@Epica3055 Epica3055 Awaiting requested review from Epica3055

Assignees

@ricardobossan ricardobossan

Labels
None yet
Projects
None yet
Milestone
10.0 Preview2
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardobossan @chaowendy @Tanya-Solyanik