-
Notifications
You must be signed in to change notification settings - Fork 139
Open
dotnet/source-build-reference-packages
#1613Labels
area-buildImprovements in source-build's own build processImprovements in source-build's own build process
Description
Newtonsoft.Json has a file version that is missing the 4th component (revision):
- MSFT:
FileVersion:13.0.3.27908,FileVersionNumber:13.0.3.27908 - SB:
FileVersion:13.0.3,FileVersionNumber:13.0.3.0
The source-build project newtonsoft-json.proj does not pass any version overrides (no /p:FileVersion=, /p:Version=, etc.). The upstream Newtonsoft build uses a PowerShell-based build script (not dotnet build) that sets a CI-specific build revision in the FileVersion (27908). Since the SB build uses dotnet pack without a FileVersion override, the 4th component defaults to 0.
Affected DLLs
Newtonsoft.Json.dll
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-buildImprovements in source-build's own build processImprovements in source-build's own build process
Type
Projects
Status
11.0