Skip to content

Newtonsoft.Json file version is missing revision component #5511

@mthalman

Description

@mthalman

Newtonsoft.Json has a file version that is missing the 4th component (revision):

  • MSFT: FileVersion:13.0.3.27908, FileVersionNumber:13.0.3.27908
  • SB: FileVersion:13.0.3, FileVersionNumber:13.0.3.0

The source-build project newtonsoft-json.proj does not pass any version overrides (no /p:FileVersion=, /p:Version=, etc.). The upstream Newtonsoft build uses a PowerShell-based build script (not dotnet build) that sets a CI-specific build revision in the FileVersion (27908). Since the SB build uses dotnet pack without a FileVersion override, the 4th component defaults to 0.

Affected DLLs

  • Newtonsoft.Json.dll

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-buildImprovements in source-build's own build process

    Type

    No type

    Projects

    Status

    11.0

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions