Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateBaselineUpdatePR tool should merge in latest #4428

Closed
ellahathaway opened this issue May 24, 2024 · 1 comment · Fixed by dotnet/sdk#41160
Closed

CreateBaselineUpdatePR tool should merge in latest #4428

ellahathaway opened this issue May 24, 2024 · 1 comment · Fixed by dotnet/sdk#41160
Assignees
Labels
area-testing Improvements in CI and testing

Comments

@ellahathaway
Copy link
Member

In dotnet/sdk#41131 it was discovered that the PR creation tool does not pull the latest in from the target branch when updating an existing PR. This leads to a situation where the PR creation tool compares updated files with the latest commit on the target branch. Consequently, the PR gets updated with files from the target branch, making it seem as if those files were modified in the PR itself, when in fact they already existed in the target branch, simply because the latest changes from the target branch weren't merged.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Improvements in CI and testing
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants