Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a new launch profile type to launch the project in a container #40880

Open
baronfel opened this issue May 14, 2024 · 1 comment
Open
Assignees
Labels
Area-CLI Area-Containers Related to dotnet SDK containers functionality Area-Watch
Milestone

Comments

@baronfel
Copy link
Member

Is your feature request related to a problem? Please describe.

The CLI doesn't have a native ability to run a project inside a container, while Visual Studio and Visual Studio Code do via Docker tools plugins for those respective editors. We should expand this support to the CLI via a new launch profile launch type, so that the intent to use a container can be uniformly expressed. Then any tooling that wants to launch a project as a container natively could interpret this launch profile type and map that to whatever mechanism of action was correct for that environment.

Describe the solution you'd like

We should define a new launch type that directs the host to create a container for the project in question, then executes it. This launch profile should be able to control key aspects of the container execution, including:

  • container engine to use
    • (docker/podman/other - our current default is docker)
  • arguments to provide to the application
    • optionally - completely overriding the entrypoint?
  • environment variables to specify when the container runs
  • volume mounts to create when the container runs
    • useful for config, secrets, etc
  • ports to map when the container runs
    • if not specified, the host could map to random available ports

References

cc @DamianEdwards @davidfowl @danegsta

@baronfel baronfel added Area-CLI Area-Watch Area-Containers Related to dotnet SDK containers functionality labels May 14, 2024
@baronfel baronfel self-assigned this May 14, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label May 14, 2024
@baronfel baronfel added the needs team triage Requires a full team discussion label May 15, 2024
@marcpopMSFT marcpopMSFT removed untriaged Request triage from a team member needs team triage Requires a full team discussion labels May 21, 2024
@marcpopMSFT marcpopMSFT added this to the 9.0.1xx milestone May 21, 2024
@marcpopMSFT
Copy link
Member

Team Triage: Marking for 9 for now but it'd be good to understand prioritization here. Additionally, launch profiles were originally a web-focused feature and who would do this work as a bit nebulous. CC @vijayrkn for his thoughts around launch profiles going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI Area-Containers Related to dotnet SDK containers functionality Area-Watch
Projects
None yet
Development

No branches or pull requests

2 participants