Skip to content

Commit 7f414bc

Browse files
authored
Disable TransitiveVersioningPinning for RoslynAnalyzers. (#78037)
Transitive pinning is breaking source-build in SDK insertions. See dotnet/sdk#48088 Changes to MissingRulesDocumentation are automated.
2 parents 502e041 + eae0d88 commit 7f414bc

File tree

4 files changed

+6
-33
lines changed

4 files changed

+6
-33
lines changed

src/RoslynAnalyzers/Directory.Build.props

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@
88

99
<!-- Set 'NoDefaultExcludes' to ensure that we can package .editorconfig files into our analyzer NuGet packages -->
1010
<NoDefaultExcludes>true</NoDefaultExcludes>
11+
12+
<!--
13+
Disabled TransitivePinning to workaround source-build issues in SDK insertions.
14+
A proper fix is being tracked by https://github.com/dotnet/roslyn/issues/78036
15+
-->
16+
<CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
1117
</PropertyGroup>
1218

1319
<!--

src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/RulesMissingDocumentation.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ RS1018 | | DiagnosticId for analyzers must be in specified format |
2323
RS1019 | | DiagnosticId must be unique across analyzers |
2424
RS1020 | | Category for analyzers must be from the specified values |
2525
RS1021 | | Invalid entry in analyzer category and diagnostic ID range specification file |
26-
RS1022 | <https://github.com/dotnet/roslyn/blob/main/docs/roslyn-analyzers/rules/RS1022.md> | Do not use types from Workspaces assembly in an analyzer |
2726
RS1024 | | Symbols should be compared for equality |
2827
RS1025 | | Configure generated code analysis |
2928
RS1026 | | Enable concurrent execution |
@@ -38,18 +37,7 @@ RS1034 | | Prefer 'IsKind' for checking syntax kinds |
3837
RS1035 | | Do not use APIs banned for analyzers |
3938
RS1036 | | Specify analyzer banned API enforcement setting |
4039
RS1037 | | Add "CompilationEnd" custom tag to compilation end diagnostic descriptor |
41-
RS1038 | <https://github.com/dotnet/roslyn/blob/main/docs/roslyn-analyzers/rules/RS1038.md> | Compiler extensions should be implemented in assemblies with compiler-provided references |
4240
RS1039 | | This call to 'SemanticModel.GetDeclaredSymbol()' will always return 'null' |
4341
RS1040 | | This call to 'SemanticModel.GetDeclaredSymbol()' will always return 'null' |
44-
RS1041 | <https://github.com/dotnet/roslyn/blob/main/docs/roslyn-analyzers/rules/RS1041.md> | Compiler extensions should be implemented in assemblies targeting netstandard2.0 |
4542
RS1042 | | Implementations of this interface are not allowed |
4643
RS1043 | | Do not use file types for implementing analyzers, generators, and code fixers |
47-
RS2000 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Add analyzer diagnostic IDs to analyzer release |
48-
RS2001 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Ensure up-to-date entry for analyzer diagnostic IDs are added to analyzer release |
49-
RS2002 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Do not add removed analyzer diagnostic IDs to unshipped analyzer release |
50-
RS2003 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Shipped diagnostic IDs that are no longer reported should have an entry in the 'Removed Rules' table in unshipped file |
51-
RS2004 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Diagnostic IDs marked as removed in analyzer release file should not be reported by analyzers |
52-
RS2005 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Remove duplicate entries for diagnostic ID in the same analyzer release |
53-
RS2006 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Remove duplicate entries for diagnostic ID between analyzer releases |
54-
RS2007 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Invalid entry in analyzer release file |
55-
RS2008 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Enable analyzer release tracking |

src/RoslynAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers/RulesMissingDocumentation.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,4 @@
22

33
Rule ID | Missing Help Link | Title |
44
--------|-------------------|-------|
5-
RS0030 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md> | Do not use banned APIs |
6-
RS0031 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md> | The list of banned symbols contains a duplicate |
75
RS0035 | | External access to internal symbols outside the restricted namespace(s) is prohibited |

src/RoslynAnalyzers/PublicApiAnalyzers/RulesMissingDocumentation.md

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,3 @@
22

33
Rule ID | Missing Help Link | Title |
44
--------|-------------------|-------|
5-
RS0016 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Add public types and members to the declared API |
6-
RS0017 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Remove deleted types and members from the declared API |
7-
RS0022 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Constructor make noninheritable base class inheritable |
8-
RS0024 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | The contents of the public API files are invalid |
9-
RS0025 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Do not duplicate symbols in public API files |
10-
RS0036 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Annotate nullability of public types and members in the declared API |
11-
RS0037 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Enable tracking of nullability of reference types in the declared API |
12-
RS0041 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Public members should not use oblivious types |
13-
RS0048 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Missing shipped or unshipped public API file |
14-
RS0050 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | API is marked as removed but it exists in source code |
15-
RS0051 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Add internal types and members to the declared API |
16-
RS0052 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Remove deleted types and members from the declared internal API |
17-
RS0053 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | The contents of the internal API files are invalid |
18-
RS0054 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Do not duplicate symbols in internal API files |
19-
RS0055 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Annotate nullability of internal types and members in the declared API |
20-
RS0056 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Enable tracking of nullability of reference types in the declared API |
21-
RS0057 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Internal members should not use oblivious types |
22-
RS0058 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Missing shipped or unshipped internal API file |
23-
RS0061 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Constructor make noninheritable base class inheritable |

0 commit comments

Comments
 (0)