Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off from VSTest so we can get test console log failures #2115

Open
joperezr opened this issue Aug 3, 2023 · 6 comments
Open

Move off from VSTest so we can get test console log failures #2115

joperezr opened this issue Aug 3, 2023 · 6 comments
Labels
bug Something isn't working Priority:2 Work that is important, but not critical for the release

Comments

@joperezr
Copy link
Member

joperezr commented Aug 3, 2023

Due to a bug in vstest, when a test fails and we are running them in parallel we may lose the console output making it impossible to debug the test failure, especially when we have flaky tests. This issue is to track the work of move away from vstest and use the runner directly to avoid this issue.

@joperezr joperezr added the bug Something isn't working label Aug 3, 2023
@ghost ghost added the untriaged label Aug 3, 2023
@Ellerbach Ellerbach added Priority:2 Work that is important, but not critical for the release and removed untriaged labels Aug 17, 2023
@ViktorHofer
Copy link
Member

cc @nohwnd

This issue is to track the work of move away from vstest and use the runner directly to avoid this issue.

Which runner do you mean? xunit.console or invoking an assembly directly with dotnet test (and with that still use the VSTest runner)? IMO moving away from VSTest to xunit.console would be unfortunate as the latter is not supported and serviced anymore.

@joperezr
Copy link
Member Author

Doesn't dotnet/runtime invoke the test runner (xunit.console) directly via their generated RunTest scripts?

@ViktorHofer
Copy link
Member

Yes, but mostly for historic reasons and because VSTest is too heavy weight for runtime's usecase. xunit.console is no longer maintained by Brad.

@raffaeler
Copy link
Contributor

@ViktorHofer do you have an alternative proposal for our repo?
We have a really hard time with the current host and apparently the solution will not happen in the near future.
Isn't better migrating to the same infrastructure used by the runtime?

@ViktorHofer
Copy link
Member

Isn't better migrating to the same infrastructure used by the runtime?

Definitely not. Our infrastructure only exists because of corner case requirements (we build the runtime ourselves) that other repositories shouldn't need to consider. I would recommend to stick using VSTest and work with their team on a path that resolves your issues so that customers would benefit from that as well.

@Evangelink @nohwnd who would be the best person to talk to about microsoft/vstest#2702 to prevent iot moving away from VSTest?

@Evangelink
Copy link
Member

Thanks for the ping @ViktorHofer! @joperezr Sending you an invite for a call (will cc you @ViktorHofer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:2 Work that is important, but not critical for the release
Projects
None yet
Development

No branches or pull requests

5 participants