Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify markdown link check #2065

Open
krwq opened this issue Apr 5, 2023 · 1 comment
Open

Simplify markdown link check #2065

krwq opened this issue Apr 5, 2023 · 1 comment
Labels
bug Something isn't working Priority:3 Work that is nice to have

Comments

@krwq
Copy link
Member

krwq commented Apr 5, 2023

I've suggested in dotnet/core usage of markdown link check but seems they found a better way to run this:

https://github.com/dotnet/core/pull/8346/files

We should consider doing it similarly (also follow up test PR if setup in fact does find errors).

And seems it's possibly to run this only on modified files which makes it even better because there will be less noise. We can consider still running checking all links as part of nightly though.

Also seems there might be easy way to set this up: https://github.com/gaurav-nelson/github-action-markdown-link-check

image

@krwq krwq added the bug Something isn't working label Apr 5, 2023
@ghost ghost added the untriaged label Apr 5, 2023
@mairaw
Copy link

mairaw commented Apr 5, 2023

you can schedule a full scan as a cron job similar to https://github.com/GoogleChrome/lighthouse/blob/main/.github/workflows/cron-weekly.yml

That's a good idea. I'll do the same for dotnet/core.

@krwq krwq added the Priority:3 Work that is nice to have label May 4, 2023
@ghost ghost removed the untriaged label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:3 Work that is nice to have
Projects
None yet
Development

No branches or pull requests

2 participants