Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce UTF-8 no BOM on files #2059

Open
krwq opened this issue Mar 23, 2023 · 3 comments
Open

Enforce UTF-8 no BOM on files #2059

krwq opened this issue Mar 23, 2023 · 3 comments
Labels
enhancement New feature or request Priority:3 Work that is nice to have

Comments

@krwq
Copy link
Member

krwq commented Mar 23, 2023

We should remove BOM from all files and add some enforcement so we don't change it back by accident.

@krwq krwq added bug Something isn't working Priority:3 Work that is nice to have labels Mar 23, 2023
@ghost ghost added the untriaged label Mar 23, 2023
@krwq krwq added enhancement New feature or request and removed bug Something isn't working untriaged labels Mar 23, 2023
@gfoidl
Copy link
Member

gfoidl commented Mar 24, 2023

some enforcement so we don't change it back by accident

Is .editorconfig enough for this?

@krwq
Copy link
Member Author

krwq commented Mar 24, 2023

yes, we currently enforce reverse :-) we need to convert all files as part of this issue :-) Better if we add some simple check as part of the build (not required though to mark this as complete)

@pgrawehr
Copy link
Contributor

Do we have a documentation why this should be an improvement? I'm still fearing that removing the BOM will result in different editors/OSes breaking non-ascii characters in our code files. And we have quite a few of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:3 Work that is nice to have
Projects
None yet
Development

No branches or pull requests

3 participants