Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWM is not enabled on all machines #2052

Open
krwq opened this issue Mar 17, 2023 · 2 comments
Open

PWM is not enabled on all machines #2052

krwq opened this issue Mar 17, 2023 · 2 comments
Labels
bug Something isn't working Priority:2 Work that is important, but not critical for the release

Comments

@krwq
Copy link
Member

krwq commented Mar 17, 2023

Some machines like ddvsorpil019 are not able to run PWM tests while some other ddvsorpil016 can.

Here is how it manifests:

    System.Device.Gpio.Tests.PwmTests.ChangingFrequency_UpdatesDutyCycle [FAIL]
      System.ArgumentException : The chip number 0 is invalid or is not enabled.
      Stack Trace:
        /_/src/System.Device.Gpio/System/Device/Pwm/Channels/UnixPwmChannel.cs(176,0): at System.Device.Pwm.Channels.UnixPwmChannel.Validate()
        /_/src/System.Device.Gpio/System/Device/Pwm/Channels/UnixPwmChannel.cs(43,0): at System.Device.Pwm.Channels.UnixPwmChannel..ctor(Int32 chip, Int32 channel, Int32 frequency, Double dutyCycle)
        /_/src/System.Device.Gpio/System/Device/Pwm/PwmChannel.cs(79,0): at System.Device.Pwm.PwmChannel.Create(Int32 chip, Int32 channel, Int32 frequency, Double dutyCyclePercentage)
        /_/src/System.Device.Gpio.Tests/SetupHelpers.cs(76,0): at System.Device.Gpio.Tests.SetupHelpers.CreatePwmChannelCore(Int32 frequency, Double dutyCycle)
        /_/src/System.Device.Gpio.Tests/SetupHelpers.cs(88,0): at System.Device.Gpio.Tests.SetupHelpers.CreatePwmChannel(Int32 frequency, Boolean stopped, Double dutyCycle)
        /_/src/System.Device.Gpio.Tests/PwmTests.cs(87,0): at System.Device.Gpio.Tests.PwmTests.ChangingFrequency_UpdatesDutyCycle()

@Ellerbach is testing if we can enable PWM programmatically with Board somehow.

In the meantime those tests are disabled here: #2051

<XUnitArguments>$(XUnitArguments) -notrait feature=pwm</XUnitArguments>

@krwq krwq added bug Something isn't working Priority:1 Work that is critical for the release, but we could probably ship without labels Mar 17, 2023
@ghost ghost added the untriaged label Mar 17, 2023
@krwq krwq removed the untriaged label Mar 17, 2023
@krwq
Copy link
Member Author

krwq commented Jun 22, 2023

[Triage] We're working on the fix

@krwq krwq added Priority:2 Work that is important, but not critical for the release and removed Priority:1 Work that is critical for the release, but we could probably ship without labels Aug 24, 2023
@krwq
Copy link
Member Author

krwq commented Aug 24, 2023

[Triage] we're not seeing original issue anymore. We should still make it easy to enable PWM somehow with a script or other way but it's not urgent anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:2 Work that is important, but not critical for the release
Projects
None yet
Development

No branches or pull requests

1 participant