CustomAttributeExtensions.xml

[wstaelens]

https://docs.microsoft.com/en-us/dotnet/api/system.reflection.customattributeextensions.getcustomattributes?view=netframework-4.8

It is not clear if the generic methods, like: GetCustomAttributes<T>(Assembly) searching inherit or not. Because the "regular" GetCustomAttributes" methods e.g. from System.Reflection.Assembly have a boolean parameter inherit.

The ones from the extensions are missing this inherit parameter!

[KalleOlaviNiemitalo]

All CustomAttributeExtensions.GetCustomAttributes overloads that don't have a bool inherit parameter behave as if inherit == true. However, in the overloads that have an Assembly or Module parameter, inheritdoes not normally matter because assemblies and modules cannot inherit attributes anyway.

I suppose inherit could matter if you were to derive a class from Assembly or Module and override the GetCustomAttributes methods there.

[wstaelens]

documentation is just not clear about it how it behaves or searches.

[Thraka]

Perhaps @steveharter or @GrabYourPitchforks can clarify?

[steveharter]

The current documentation should be updated to reflect that the "inherit" behavior is true for the methods that don't have the inherit parameter. So text like "The ancestors of element are also inspected" should be added to the overloads of MemberInfo and ParameterInfo when inherit is not specified.

[wstaelens]

4 years later, I had to search again if they were included or not...

That documentation should be added/updated with this information.