Skip to content

Scope the product EOL date to repos #1553

@mthalman

Description

@mthalman

The logic which computes the EOL annotations that need to be applied has an option for querying the .NET releases JSON file to determine the EOL dates of .NET versions:

if (Options.AnnotateEolProducts)
{
// Annotate images for EOL products in new image info
// Only do so for those digests that actually exist in the registry (they may have been cleaned up
// because they are EOL).
IEnumerable<EolDigestData> eolDigests =
newImageArtifactDetails.Repos
.SelectMany(repo =>
repo.Images
.SelectMany(image => GetProductEolDigests(image, productEolDates)))
.Where(digestData => registryTagsByDigest.ContainsKey(digestData.Digest));
digestDataList.AddRange(eolDigests);
}

It associates those dates with the Dockerfiles having the same .NET version. This is fine for the core repos like runtime, aspnet, and sdk because the images in those repos follow the same versioning as the main .NET product. But in cases like YARP which have their own separate versioning, it's not applicable. There is danger of those versions matching an EOL .NET version and having those images incorrectly annotated as EOL when they're not.

So there's a need to be able to scope the product EOL date to specific repos so that it won't match on other repos where those dates aren't applicable.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions