-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pipeline variable to reference MAR Status API resource/scope #1288
Labels
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
It would probably make sense to define this in our Dotnet-Docker-Common variable group. |
There is a WIP branch for this here - https://github.com/lbussell/docker-tools/tree/issue-1288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we hardcode the resource scope for the MAR status API:
docker-tools/src/Microsoft.DotNet.ImageBuilder/src/McrStatusClient.cs
Line 20 in 7b8f032
This is very inflexible and requires changes to our source code if we need to change where this points to. Instead, we should accept a scope via the CLI and pass it in via an environment variable so that we can change it as needed without rebuilding ImageBuilder. We don't intend to frequently access this API on dev machines, so this should be an acceptable solution.
The text was updated successfully, but these errors were encountered: