Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run docker-tools-eng-validation-pr pipeline as part of PR validation when there are changes to ImageBuilder #1255

Open
lbussell opened this issue Apr 25, 2024 · 3 comments

Comments

@lbussell
Copy link
Contributor

We have two PR validation pipelines in this repo.

  1. The ImageBuilder build pipeline
  2. Define a pipeline that runs a fake build through the common pipeline infra #305

This eng validation pipeline runs only when there are changes to the eng/ folder:

pr:
branches:
include:
- main
paths:
include:
- eng/*
- test/*

However, this does not check when changes in ImageBuilder could affect the way the eng-validation pipeline runs, since it uses the version of ImageBuilder from MAR.

To provide a check for this, we should change the eng-validation pipeline to build and run a new ImageBuilder image, and use that image to run the regular eng-validation-pr pipeline.

One unknown to solve here is how to pass artifacts between stages of public pipeline builds if we don't have access to an ACR. A potential solution to explore is writing the image to the disk and loading it in each successive stage.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@lbussell
Copy link
Contributor Author

[Triage] One downside to this approach would be that we wouldn't test the exact same codepath as the normal eng-validation pipeline if we decide to add extra jobs or stages that inject a new version of ImageBuilder.

@lbussell
Copy link
Contributor Author

Another downside to this would be that if an ImageBuilder change required pipeline changes that are incompatible with the current ImageBuilder version, then CI could never pass (one of the two would always fail - ImageBuilder's Build pipeline or the eng. validation pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant