Skip to content

Commit 8c8e583

Browse files
richlanderrichlander
authored
Fix linter errors in repo (#9689)
* Fix linter errors * Update links
1 parent f82833a commit 8c8e583

File tree

3,212 files changed

+48616
-57661
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

3,212 files changed

+48616
-57661
lines changed

‎CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# Code of Conduct
22

33
This project uses the [.NET Foundation Code of Conduct](https://dotnetfoundation.org/code-of-conduct) to define expected conduct in our community.
4-
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting a project maintainer at [email protected].
4+
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting a project maintainer at <[email protected]>.

‎CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
See [Contributing](https://github.com/dotnet/runtime/blob/main/CONTRIBUTING.md) for information about coding styles, source structure, making pull requests, and more.
44

5-
# Repositories
5+
## Repositories
66

77
See the [.NET Repos](Documentation/core-repos.md) to find a repo to contribute to.

‎Documentation/contributing/maintainers.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ The .NET maintainer team aims to support a productive and safe working environme
44

55
The following two lists summarize how maintainers will act. A more detailed description follows this summary.
66

7-
**Maintainers will**
7+
Maintainers will:
8+
89
- Encourage your contributions and participation and provide clear and direct feedback, including when your contributions are not accepted.
910
- Close issues and PRs as a means of making repos more efficient to use for everyone. They can be re-opened, as needed.
1011
- Edit comments for formatting [if and only if (iff)](https://en.wikipedia.org/wiki/If_and_only_if) the edit adds substantially to the readability or usability of the comment. No changes will be made to spelling, wording, meaning, or emphasis.
1112
- Report abusive behavior to the [Code of Conduct review group](mailto:[email protected]).
1213

13-
**Maintainers won't**
14+
Maintainers won't:
15+
1416
- Edit contributor comments as a general rule. GitHub provides [edit history](https://blog.github.com/changelog/2018-05-24-comment-edit-history/) which makes editing more acceptable as there is a way to see an audit log. However, contributors might still be surprised when they see statements or phrases under their name that they don't recall making. Transparency is a cornerstone of effective discourse and its absence undermines trust. And a change log doesn't fully eliminate these concerns.
1517

1618
## Respect your Contributions
@@ -27,7 +29,7 @@ Maintainers will take actions to make repo engagement more efficient for everyon
2729

2830
Maintainers may edit PR and issue titles to improve readability and/or accuracy. GitHub provides history for title changes.
2931

30-
Maintainers may edit your comments if and only if the edit adds substantially to the readability or usability of the comment and doesn't change the content. The maintainer will add a short descriptive note with their @handle to explain their change at the end of your comment (for example: "_Edited by @richlander -- added call-stack formatting_").
32+
Maintainers may edit your comments if and only if the edit adds substantially to the readability or usability of the comment and doesn't change the content. The maintainer will add a short descriptive note with their @handle to explain their change at the end of your comment (for example: "_Edited by @richlander -- added call-stack formatting_").
3133

3234
Maintainers may make the following changes to contributor comments:
3335

‎Documentation/core-repos.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
|[dotnet/runtime](https://github.com/dotnet/runtime) |[🔗](https://github.com/dotnet/runtime/issues) |[🔗](https://github.com/dotnet/runtime/discussions) |.NET runtime, runtime installers, application model, & Base Class Library (BCL)|
1111
|[dotnet/sdk](https://github.com/dotnet/sdk) |[🔗](https://github.com/dotnet/sdk/issues) | |.NET SDK (used by Visual Studio & .NET CLI)|
1212

13-
1413
## Compilers & Languages
14+
1515
|Repository |Issues |Discussions | Description |
1616
|--------------------------------------------------------------------|:----------------------------------------------------:|:--------------------------------------------------------:|-------------|
1717
|[dotnet/csharplang](https://github.com/dotnet/csharplang) |[🔗](https://github.com/dotnet/csharplang/issues) |[🔗](https://github.com/dotnet/csharplang/discussions) |C# suggestions, specification, ongoing language design |
@@ -48,7 +48,7 @@
4848
|Repository |Issues |Discussions | Description |
4949
|--------------------------------------------------------------------|:-----------------------------------------------:|:---------------------------------------------------:|------------|
5050
|[dotnet/dotnet-docker](https://github.com/dotnet/dotnet-docker) |[🔗](https://github.com/dotnet/dotnet-docker/issues) |[🔗](https://github.com/dotnet/dotnet-docker/discussions)|.NET Docker images|
51-
|[dotnet/installer](https://github.com/dotnet/installer) |[🔗](https://github.com/dotnet/installer/issues) | |.NET installer (produces zips, tarballs, and installers for the .NET SDK)
51+
|[dotnet/installer](https://github.com/dotnet/installer) |[🔗](https://github.com/dotnet/installer/issues) | |.NET installer (produces zips, tarballs, and installers for the .NET SDK) |
5252
|[dotnet/machinelearning-modelbuilder](https://github.com/dotnet/machinelearning-modelbuilder) |[🔗](https://github.com/dotnet/machinelearning-modelbuilder/issues) | |ML.NET Tooling |
5353
|[dotnet/msbuild](https://github.com/dotnet/msbuild) |[🔗](https://github.com/dotnet/msbuild/issues)|[🔗](https://github.com/dotnet/msbuild/discussions)|Build platform for .NET & Visual Studio|
5454
|[dotnet/Scaffolding](https://github.com/dotnet/Scaffolding) |[🔗](https://github.com/dotnet/Scaffolding/issues) | |ASP.NET Core code generators |
@@ -58,7 +58,6 @@
5858
|[dotnet/test-templates](https://github.com/dotnet/test-templates) |[🔗](https://github.com/dotnet/test-templates/issues) | |.NET unit testing project templates|
5959
|[dotnet/vscode-csharp](https://github.com/dotnet/vscode-csharp) |[🔗](https://github.com/dotnet/vscode-csharp/issues) |[🔗](https://github.com/dotnet/vscode-csharp/discussions) |C# support for VS Code|
6060

61-
6261
## NuGet
6362

6463
|Repository |Issues |Discussions | Description |

‎Documentation/diagnostics/portable_pdb.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
This document has moved to https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/portable-pdb.md
1+
# File has moved
2+
3+
This document has moved to <https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/portable-pdb.md>

‎Documentation/diagnostics/source_link.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
This document has moved to https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/source-link.md
1+
# File has moved
2+
3+
This document has moved to <https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/source-link.md>

‎Documentation/ilcRepro.md

Lines changed: 91 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,12 @@
22

33
It looks like you probably hit a bug in .NET Native.
44
You can help make .NET better by sending a bug report.
5-
However, take a look at the [Known Issues](#known-issues) section below
6-
before sending a bug report. There may already be a
7-
workaround for your issue.
85

96
## Creating and Sending a .NET Native repro
107

118
1. Add `<NetNativeReproPath>C:\myReproDirectory</NetNativeReproPath>` to the primary PropertyGroup in your project file, the file ending in csproj, vsproj, vcxproj, or jsproj. You can set `C:\myReproDirectory` to any directory that exists. [Examples are below.](#examples)
129
2. Rebuild your app. You will find ilcRepro.zip in the repro directory you specified above.
13-
3. Put ilcRepro.zip on your OneDrive, Dropbox, or another storage provider. Send a link to ilcRepro.zip and a description of your issue to [email protected].
10+
3. Put ilcRepro.zip on your OneDrive, Dropbox, or another storage provider. Send a link to ilcRepro.zip and a description of your issue to <[email protected]>.
1411
4. Remove `<NetNativeReproPath>` from your project file.
1512

1613
## Compilation Failure in Store
@@ -19,102 +16,110 @@ UWP apps containing managed code are compiled in Store using the .NET Native Too
1916

2017
`This submission failed due to compilation error {0}. More information about this error can be found here.`
2118

22-
In such a case, please ensure that you were able to build your application in Release mode successfully at the time you submitted it to Store. If it did, please send the error number you got in the message above and email [email protected].
19+
In such a case, please ensure that you were able to build your application in Release mode successfully at the time you submitted it to Store. If it did, please send the error number you got in the message above and email <[email protected]>.
2320

24-
For help with any other issues, please share their details at https://connect.microsoft.com/visualstudio/
21+
For help with any other issues, please share their details at <https://connect.microsoft.com/visualstudio/>
2522

2623
## Examples
2724

2825
Below are examples of where to add the `<NetNativeReproPath>` tag.
2926

3027
### C# (*.csproj)
3128

32-
<?xml version="1.0" encoding="utf-8"?>
33-
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
34-
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
35-
<PropertyGroup>
36-
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
37-
<Platform Condition=" '$(Platform)' == '' ">x86</Platform>
38-
<ProjectGuid>{B44664F5-278C-4ABE-B62E-A5CA20E3DC48}</ProjectGuid>
39-
<OutputType>AppContainerExe</OutputType>
40-
<AppDesignerFolder>Properties</AppDesignerFolder>
41-
<RootNamespace>App1</RootNamespace>
42-
<AssemblyName>App1</AssemblyName>
43-
<DefaultLanguage>en-US</DefaultLanguage>
44-
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
45-
<TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion>
46-
<TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion>
47-
<MinimumVisualStudioVersion>14</MinimumVisualStudioVersion>
48-
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
49-
<FileAlignment>512</FileAlignment>
50-
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
51-
<PackageCertificateKeyFile>App1_TemporaryKey.pfx</PackageCertificateKeyFile>
52-
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
53-
</PropertyGroup>
54-
⋮
55-
</Project>
29+
```xml
30+
<?xml version="1.0" encoding="utf-8"?>
31+
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
32+
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
33+
<PropertyGroup>
34+
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
35+
<Platform Condition=" '$(Platform)' == '' ">x86</Platform>
36+
<ProjectGuid>{B44664F5-278C-4ABE-B62E-A5CA20E3DC48}</ProjectGuid>
37+
<OutputType>AppContainerExe</OutputType>
38+
<AppDesignerFolder>Properties</AppDesignerFolder>
39+
<RootNamespace>App1</RootNamespace>
40+
<AssemblyName>App1</AssemblyName>
41+
<DefaultLanguage>en-US</DefaultLanguage>
42+
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
43+
<TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion>
44+
<TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion>
45+
<MinimumVisualStudioVersion>14</MinimumVisualStudioVersion>
46+
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
47+
<FileAlignment>512</FileAlignment>
48+
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
49+
<PackageCertificateKeyFile>App1_TemporaryKey.pfx</PackageCertificateKeyFile>
50+
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
51+
</PropertyGroup>
52+
⋮
53+
</Project>
54+
```
5655

5756
### VB (*.vbproj)
5857

59-
<?xml version="1.0" encoding="utf-8"?>
60-
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
61-
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
62-
<PropertyGroup>
63-
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
64-
<Platform Condition=" '$(Platform)' == '' ">x86</Platform>
65-
<ProjectGuid>{8C7ADA9E-47DF-4937-A1D9-62CA9B88A100}</ProjectGuid>
66-
<OutputType>AppContainerExe</OutputType>
67-
<RootNamespace>App4</RootNamespace>
68-
<AssemblyName>App4</AssemblyName>
69-
<DefaultLanguage>en-US</DefaultLanguage>
70-
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
71-
<TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion>
72-
<TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion>
73-
<MinimumVisualStudioVersion>14</MinimumVisualStudioVersion>
74-
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
75-
<FileAlignment>512</FileAlignment>
76-
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{F184B08F-C81C-45F6-A57F-5ABD9991F28F}</ProjectTypeGuids>
77-
<PackageCertificateKeyFile>App4_TemporaryKey.pfx</PackageCertificateKeyFile>
78-
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
79-
</PropertyGroup>
80-
⋮
81-
</Project>
58+
```xml
59+
<?xml version="1.0" encoding="utf-8"?>
60+
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
61+
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
62+
<PropertyGroup>
63+
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
64+
<Platform Condition=" '$(Platform)' == '' ">x86</Platform>
65+
<ProjectGuid>{8C7ADA9E-47DF-4937-A1D9-62CA9B88A100}</ProjectGuid>
66+
<OutputType>AppContainerExe</OutputType>
67+
<RootNamespace>App4</RootNamespace>
68+
<AssemblyName>App4</AssemblyName>
69+
<DefaultLanguage>en-US</DefaultLanguage>
70+
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
71+
<TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion>
72+
<TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion>
73+
<MinimumVisualStudioVersion>14</MinimumVisualStudioVersion>
74+
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
75+
<FileAlignment>512</FileAlignment>
76+
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{F184B08F-C81C-45F6-A57F-5ABD9991F28F}</ProjectTypeGuids>
77+
<PackageCertificateKeyFile>App4_TemporaryKey.pfx</PackageCertificateKeyFile>
78+
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
79+
</PropertyGroup>
80+
⋮
81+
</Project>
82+
```
8283

8384
### C++ (*.vcxproj)
8485

85-
<?xml version="1.0" encoding="utf-8"?>
86-
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
87-
<PropertyGroup Label="Globals">
88-
<ProjectGuid>{74010e92-8ead-4acc-8fc6-7db385af579b}</ProjectGuid>
89-
<RootNamespace>App2</RootNamespace>
90-
<DefaultLanguage>en-US</DefaultLanguage>
91-
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
92-
<AppContainerApplication>true</AppContainerApplication>
93-
<ApplicationType>Windows Store</ApplicationType>
94-
<WindowsTargetPlatformVersion>10.0.10158.0</WindowsTargetPlatformVersion>
95-
<WindowsTargetPlatformMinVersion>10.0.10158.0</WindowsTargetPlatformMinVersion>
96-
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
97-
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
98-
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
99-
</PropertyGroup>
100-
⋮
101-
</Project>
86+
```xml
87+
<?xml version="1.0" encoding="utf-8"?>
88+
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
89+
<PropertyGroup Label="Globals">
90+
<ProjectGuid>{74010e92-8ead-4acc-8fc6-7db385af579b}</ProjectGuid>
91+
<RootNamespace>App2</RootNamespace>
92+
<DefaultLanguage>en-US</DefaultLanguage>
93+
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
94+
<AppContainerApplication>true</AppContainerApplication>
95+
<ApplicationType>Windows Store</ApplicationType>
96+
<WindowsTargetPlatformVersion>10.0.10158.0</WindowsTargetPlatformVersion>
97+
<WindowsTargetPlatformMinVersion>10.0.10158.0</WindowsTargetPlatformMinVersion>
98+
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
99+
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
100+
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
101+
</PropertyGroup>
102+
⋮
103+
</Project>
104+
```
102105

103106
### JS (*.jsproj)
104107

105-
<?xml version="1.0" encoding="utf-8"?>
106-
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
107-
⋮
108-
<PropertyGroup>
109-
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
110-
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
111-
<TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion>
112-
<TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion>
113-
<MinimumVisualStudioVersion>$(VersionNumberMajor).$(VersionNumberMinor)</MinimumVisualStudioVersion>
114-
<DefaultLanguage>en-US</DefaultLanguage>
115-
116-
<PackageCertificateKeyFile>App3_TemporaryKey.pfx</PackageCertificateKeyFile>
117-
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
118-
</PropertyGroup>
119-
⋮
120-
</Project>
108+
```xml
109+
<?xml version="1.0" encoding="utf-8"?>
110+
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
111+
⋮
112+
<PropertyGroup>
113+
<EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile>
114+
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
115+
<TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion>
116+
<TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion>
117+
<MinimumVisualStudioVersion>$(VersionNumberMajor).$(VersionNumberMinor)</MinimumVisualStudioVersion>
118+
<DefaultLanguage>en-US</DefaultLanguage>
119+
120+
<PackageCertificateKeyFile>App3_TemporaryKey.pfx</PackageCertificateKeyFile>
121+
<NetNativeReproPath>C:\myRepro</NetNativeReproPath>
122+
</PropertyGroup>
123+
⋮
124+
</Project>
125+
```

‎Documentation/microsoft-team.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ Register at least two of the following two-factor authentication methods:
1919
* [Hardware security key(s)](https://docs.github.com/authentication/securing-your-account-with-two-factor-authentication-2fa/configuring-two-factor-authentication#configuring-two-factor-authentication-using-a-security-key) (also see [yubikey](https://www.yubico.com/works-with-yubikey/catalog/github/))
2020
* [TOTP with an Authenticator app](https://docs.github.com/authentication/securing-your-account-with-two-factor-authentication-2fa/configuring-two-factor-authentication#configuring-two-factor-authentication-using-a-totp-mobile-app) (like [Microsoft Authenticator](https://support.microsoft.com/account-billing/download-and-install-the-microsoft-authenticator-app-351498fc-850a-45da-b7b6-27e523b8702a))
2121

22-
2322
Additional guidance:
2423

2524
* Do not use [SMS](https://en.wikipedia.org/wiki/SIM_swap_scam) for 2FA or as a recovery fallback (disable those options).

0 commit comments

Comments
 (0)