Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in fastify integration documentation example #3763

Open
Fenykepy opened this issue Feb 15, 2025 · 3 comments
Open

Error in fastify integration documentation example #3763

Fenykepy opened this issue Feb 15, 2025 · 3 comments

Comments

@Fenykepy
Copy link
Contributor

Describe the bug

I found an error in fastify integration documentation:
https://github.com/dotansimha/graphql-yoga/blob/main/website/src/content/docs/integrations/integration-with-fastify.mdx

app.listen(4000) needs to be replaced by app.listen({ port: 4000}).
I know it's not a big deal but it could help some beginners (like me).

Your Example Website or App

none

Steps to Reproduce the Bug or Issue

none

Expected behavior

Updated documentation.

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • NodeJS: [e.g. 18.1.0]
  • @graphql-yoga/* version(s): [e.g. 2.5.1]

Additional context

No response

@ardatan
Copy link
Collaborator

ardatan commented Feb 15, 2025

Thanks for the feedback! Would you create a PR for this change in the docs?

@Urigo Urigo changed the title Error in fastify intregration documentation example Error in fastify integration documentation example Feb 15, 2025
@Fenykepy
Copy link
Contributor Author

Just done it there:
#3765

@ardatan
Copy link
Collaborator

ardatan commented Feb 15, 2025

Merged! Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants