You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.
The issue can be reproduced on the latest available commit of Doom.
The issue can be reproduced on a stable release of Emacs, such as 27 or 28. (Doom does not support development builds like 29+ or any version ending in .50 or .9x)
Expected behavior
In a gdscript-mode buffer, SPC m d a should create a breakpoint and SPC m d d should remove one.
Current behavior
The two bindings produce error messages:
Wrong type argument: commandp, gdscript-debug-add-breakpoint
Wrong type argument: commandp, gdscript-debug-remove-breakpoint
Respectively.
These functions do not exist in the gdscript-mode package, and have not since 2021. They were removed in this upstream commit. The successor to these functions, gdscript-debug-toggle-breakpoint, was introduced in the same commit (and bound to <f9> by default).
Recently, after a long dormant period, the upstream package has found new maintainers, who are currently working on updating it for the changes introduced in Godot 4.0. (There's eglot support now!) Quoting from a recent commit to the README:
"The debugger in this package is only for Godot 3. Godot 4 supports the Debugger Adapter Procol (DAP), which you can use with the dap-mode package."
I confirm that...
I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.
I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.
The issue can be reproduced on the latest available commit of Doom.
The issue can be reproduced on a stable release of Emacs, such as 27 or 28. (Doom does not support development builds like 29+ or any version ending in .50 or .9x)
Expected behavior
In a
gdscript-mode
buffer,SPC m d a
should create a breakpoint andSPC m d d
should remove one.Current behavior
The two bindings produce error messages:
Respectively.
These functions do not exist in the
gdscript-mode
package, and have not since 2021. They were removed in this upstream commit. The successor to these functions,gdscript-debug-toggle-breakpoint
, was introduced in the same commit (and bound to<f9>
by default).Recently, after a long dormant period, the upstream package has found new maintainers, who are currently working on updating it for the changes introduced in Godot 4.0. (There's eglot support now!) Quoting from a recent commit to the README:
"The debugger in this package is only for Godot 3. Godot 4 supports the Debugger Adapter Procol (DAP), which you can use with the dap-mode package."
So it might be time to rethink the keybindings for the debugger altogether.
dap-mode
upstream recently added support for Godot 4.Steps to reproduce
SPC m d d
System Information
https://pastebin.com/d9kzU0Up
The text was updated successfully, but these errors were encountered: