Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corfu: When in prog-mode indenting with tab does not work #7767

Open
4 tasks done
Schievel1 opened this issue Mar 27, 2024 · 3 comments
Open
4 tasks done

Corfu: When in prog-mode indenting with tab does not work #7767

Schievel1 opened this issue Mar 27, 2024 · 3 comments
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet

Comments

@Schievel1
Copy link
Contributor

Schievel1 commented Mar 27, 2024

I confirm that...

  • I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.

  • I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.

  • The issue can be reproduced on the latest available commit of Doom.

  • The issue can be reproduced on a stable release of Emacs, such as 27, 28, or 29. (Unstable versions end in .50, .60, or .9x)

Expected behavior

In company-mode pressing TAB when e.g. c-mode is active and in insert-state will indent the line, unless it is already indented to the right position, the it will start company-complete.
This seems to depend on the setting of tab-always-indent.

Current behavior

When I activate the corfu module instead (and deactivate the company module) TAB always tries to start completion-at-point (it seems, it says No match in the minibuffer) regardless of the indentation of the line.

Being in normal-state indents the line like it should be.
Also (setq c-tab-always-indent nil) does not seem to have an effect at all. Normally this would insert actual tabs if the point is at the end of the line.

Steps to reproduce

  1. install corfu module
  2. open a .c file
  3. go to a line which isn't indented correctly
  4. press tab

I also changed config.el from the company module and set tab-always-indent in there to nil, but that doesn't do the trick.
Also setting that in c-mode hook or corfu-mode-hook does not work.

System Information

https://pastebin.com/xHcHEWhW
Yes I know this is Emacs 29.50, but I can reproduce on a plain Emacs 29 as well.

@Schievel1 Schievel1 added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Mar 27, 2024
@j-palms
Copy link

j-palms commented Mar 27, 2024

This is already adressed in #7739 (and just the fix would be this #7746).
Until this is merged I'm using C-i instead.

@Schievel1
Copy link
Contributor Author

Ok, thanks. I checked the issues if someone elses reported that but I haven't checked the PRs if someone fixed it already.

@davidbudzynski
Copy link

I'm experiencing the same issue, so merging the PR would be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet
Projects
Status: Unreviewed
Development

No branches or pull requests

3 participants