Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Dependency anaylsis on lookup joins doesn't handle when key expression is an Arithmetic expression #1893

Open
nicktobey opened this issue Jul 24, 2023 · 0 comments

Comments

@nicktobey
Copy link
Contributor

Put a breakpoint in lookupJoinSelectivity before the call to sql.NewLookupFDs

Run the following SQL:

CREATE table xy (x int primary key, y int);
CREATE table uv (u int primary key, v int);
insert into xy values (1,0), (2,1), (0,2), (3,3);
insert into uv values (0,1), (1,1), (2,2), (3,2);
SELECT * FROM xy WHERE (
      				EXISTS (SELECT * FROM xy Alias1 WHERE Alias1.x = (xy.x + 1)));

As part of costing joins, we attempt to detect lookups that we know will always return at most one row. This is a perfect candidate of such a lookup: We use xy.x+1 as the key into a lookup on the primary key index Alias1.x. This always has at most one result. So we expect that fds.HasMax1Row() within lookupJoinSelectivity should return true. But it returns false instead, and we fail to prioritize this execution plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant