Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in code examples in resource introduction of dojo.io #846

Open
arndbeissner opened this issue Sep 25, 2020 · 0 comments
Open

Error in code examples in resource introduction of dojo.io #846

arndbeissner opened this issue Sep 25, 2020 · 0 comments
Assignees

Comments

@arndbeissner
Copy link

Bug

There are errors in the code examples in resources introduction on dojo.io. Since the resources are a very new addition and there is no widespread use in the public examples so far, these should be fixed, especially the one about the createDataMiddleware function. I just mention the second one as it's in the same document.

Package Version:

Current dojo.io for v.7 : https://dojo.io/learn/resources/introduction

Code

Expected behavior:

Code example for ResourceAwareWidget.tsx should read:
const resource = createResourceMiddleware <ResourceData>();

Code example for App.tsx should read:
const template = createMemoryResourceTemplate<{ foo: string }>();

Actual behavior:

Code example for ResourceAwareWidget.tsx reads:
const resource = createDataMiddleware<ResourceData>();

Code example for App.tsx reads:
const myTemplate = createMemoryResourceTemplate<{ foo: string }>();

@samends samends self-assigned this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants