Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does autoupgrade break the EngineIO protocol? #392

Open
zackliu opened this issue Oct 28, 2024 · 0 comments
Open

Does autoupgrade break the EngineIO protocol? #392

zackliu opened this issue Oct 28, 2024 · 0 comments

Comments

@zackliu
Copy link

zackliu commented Oct 28, 2024

I find the newly added feature autograde send a upgrade message directly, but from the protocol of Engine.IO https://socket.io/docs/v4/engine-io-protocol/#upgrade clients MUST send a ping packet with the string probe in the payload. I'm not sure whether this implementation break the protocol and may be not work in all the server implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant