-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#344 Only include STJ for Net Standard 2 #367
base: master
Are you sure you want to change the base?
#344 Only include STJ for Net Standard 2 #367
Conversation
cae6333
to
9687155
Compare
Thanks for you PR, but I don't know why need to change, could you please leave extra infos to explain it? |
when a library is compiled for a particular framework ie Net 6 a number of dependencies are provided by the framework hence the developer/publisher is not needing to include them in their release for those frameworks. |
src/SocketIO.Serializer.SystemTextJson/SocketIO.Serializer.SystemTextJson.csproj
Show resolved
Hide resolved
src/SocketIO.Serializer.SystemTextJson/SocketIO.Serializer.SystemTextJson.csproj
Show resolved
Hide resolved
I have published 2 packages to local folder, and then make the folder as a nuget source.
the condition of alpha.1 is <PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
...
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Text.Json" Version="8.0.3" />
</ItemGroup> the condition of alpha.2 is <PropertyGroup>
<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
...
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='netstandard2.0'">
<PackageReference Include="System.Text.Json" Version="8.0.3" />
</ItemGroup> next I created a .NET8 ConsoleApp and installed then I removed the alpha.1 and install the alpha.2 How to test the differences between them? commit: e9dcb3c |
Has added in Net 6 which has STJ so no need for dependency
Closes #344