Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-english characters on default search #108

Open
nbasili opened this issue Jul 3, 2013 · 2 comments
Open

Non-english characters on default search #108

nbasili opened this issue Jul 3, 2013 · 2 comments

Comments

@nbasili
Copy link

nbasili commented Jul 3, 2013

When typing a text with non-english characters on an empty visual search input, without a facet selected, the default text: ... facet does not get filled in and the text typed is lost.

Works fine for english words though.

For example:
| John | -> Enter -> | Text: John |
| Γιάννης | -> Enter -> | access: | (returns the first facet)

@knowtheory
Copy link
Member

I'm having trouble replicating the issue (and our usage in DocumentCloud does appropriately set up a text facet when you paste in Γιάννης or type in other unicode), do you happen to have a page I could hit to see what's happening?

@nbasili
Copy link
Author

nbasili commented Jul 4, 2013

You can try it here:
http://documentcloud.github.io/visualsearch/

Just clear out all fields and type in or paste the non-english text.
It seems that the problem is that when you start typing with non-english characters the facet dropdown does not get cleared out.

For example, if I type 'a' the 'access' facet is displayed. As soon as I press 'v' (av), the dropdown disappears as there is not match for 'av'. But it seems that it fails with other Unicode chars.

So it the url above, if I paste (or type) "John", the dropdown is cleared. If I paste (or type) "Γιάννης", the dropdown stays open with "access" preselected.

Tested on latest Chrome and Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants