Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jammit should warn when it fails to load an explicitly configured compressor. #257

Open
ses4j opened this issue Feb 24, 2014 · 2 comments
Open

Comments

@ses4j
Copy link

ses4j commented Feb 24, 2014

I was configured to use the Google Closure Compiler:

javascript_compressor: closure

But was unwittingly falling back to jsmin because

require 'closure-compiler'

was failing silently due to it not being installed.

@josephmisiti
Copy link

+1

@crystalneth
Copy link

Same issue. I had to add the yui-compressor gem to my rails Gemfile, despite yui compressor being the documented default and there not being any indication that the gem needs to be installed separately. Seems strange that the default compressor would not be a dependency, but a non-default compressor would be a dependency.

Jammit was falling back to jsmin without any warning or error. If my config file says yui, please fail if yui can't be loaded. Falling back is just confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants