Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: golang.org/x/crypto v0.35.0 #5869

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member


vendor: golang.org/x/sys v0.30.0

full diff: golang/sys@v0.29.0...v0.30.0

vendor: golang.org/x/sync v0.11.0

no code-changes, only a godoc comment updated

full diff: golang/sync@v0.10.0...v0.11.0

vendor: golang.org/x/text v0.22.0

no code-changes in vendored files.

full diff: golang/text@v0.21.0...v0.22.0

vendor: golang.org/x/crypto v0.34.0

No code-changes, but updates the minimum go version to go1.23:

all: upgrade go directive to at least 1.23.0 [generated]

By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
per the Go Release Policy (https://go.dev/doc/devel/release#policy).

For golang/go#69095.

full diff: golang/crypto@v0.31.0...v0.34.0

vendor: golang.org/x/crypto v0.35.0

We have tagged version v0.35.0 of golang.org/x/crypto in order to address
a security issue. Version v0.35.0 of golang.org/x/crypto fixes a vulnerability
in the golang.org/x/crypto/ssh package which could cause a denial of service.
SSH servers which implement file transfer protocols are vulnerable to a denial
of service attack from clients which complete the key exchange slowly, or not
at all, causing pending content to be read into memory, but never transmitted.
Thanks to Yuichi Watanabe for reporting this issue.
This is CVE-2025-22869 and Go issue https://go.dev/issue/71931.

full diff: golang/crypto@v0.31.0...v0.35.0

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Go maintainers started to unconditionally update the minimum go version
for golang.org/x/ dependencies to go1.23, which means that we'll no longer
be able to support any version below that when updating those dependencies;

> all: upgrade go directive to at least 1.23.0 [generated]
>
> By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
> per the Go Release Policy (https://go.dev/doc/devel/release#policy).
>
> For golang/go#69095.

This updates our minimum version to go1.23, as we won't be able to maintain
compatibility with older versions because of the above.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
no code-changes, only a godoc comment updated

full diff: golang/sync@v0.10.0...v0.11.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
no code-changes in vendored files.

full diff: golang/text@v0.21.0...v0.22.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
No code-changes, but updates the minimum go version to go1.23:

> all: upgrade go directive to at least 1.23.0 [generated]
>
> By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
> per the Go Release Policy (https://go.dev/doc/devel/release#policy).
>
> For golang/go#69095.

full diff: golang/crypto@v0.31.0...v0.34.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
We have tagged version v0.35.0 of golang.org/x/crypto in order to address
a security issue. Version v0.35.0 of golang.org/x/crypto fixes a vulnerability
in the golang.org/x/crypto/ssh package which could cause a denial of service.
SSH servers which implement file transfer protocols are vulnerable to a denial
of service attack from clients which complete the key exchange slowly, or not
at all, causing pending content to be read into memory, but never transmitted.
Thanks to Yuichi Watanabe for reporting this issue.
This is CVE-2025-22869 and Go issue https://go.dev/issue/71931.

full diff: golang/crypto@v0.31.0...v0.35.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
golang.org/x/crypto v0.34.0 // indirect
golang.org/x/crypto v0.35.0 // indirect
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No diff in vendored files for this update, so we don't need to update, other than for silencing scanners (false positive)

@thaJeztah thaJeztah changed the title Bump crypto vendor: golang.org/x/crypto v0.35.0 Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (41277f5) to head (bd860aa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5869      +/-   ##
==========================================
- Coverage   59.30%   59.27%   -0.03%     
==========================================
  Files         353      353              
  Lines       29694    29694              
==========================================
- Hits        17609    17601       -8     
- Misses      11104    11113       +9     
+ Partials      981      980       -1     

@thaJeztah thaJeztah added this to the 28.1.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants