Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimum go version to go1.23 #5868

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 25, 2025

relates to:


Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies;

all: upgrade go directive to at least 1.23.0 [generated]

By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
per the Go Release Policy (https://go.dev/doc/devel/release#policy).

For golang/go#69095.

This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above.

- Human readable description for the release notes

Go SDK: Update minimum required Go version to go1.23

- A picture of a cute animal (not mandatory but encouraged)

Go maintainers started to unconditionally update the minimum go version
for golang.org/x/ dependencies to go1.23, which means that we'll no longer
be able to support any version below that when updating those dependencies;

> all: upgrade go directive to at least 1.23.0 [generated]
>
> By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
> per the Go Release Policy (https://go.dev/doc/devel/release#policy).
>
> For golang/go#69095.

This updates our minimum version to go1.23, as we won't be able to maintain
compatibility with older versions because of the above.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added impact/changelog status/2-code-review area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Feb 25, 2025
@thaJeztah thaJeztah requested review from a team and silvin-lubecki as code owners February 25, 2025 12:00
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.30%. Comparing base (41277f5) to head (c915382).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5868   +/-   ##
=======================================
  Coverage   59.30%   59.30%           
=======================================
  Files         353      353           
  Lines       29694    29694           
=======================================
  Hits        17609    17609           
  Misses      11104    11104           
  Partials      981      981           

@thaJeztah
Copy link
Member Author

Let's discuss if we want to include this in 28.0.1, or keep this for a 28.1 release; this bump was needed if we needed #5869, but the CVE in that bump is really a false positive, so we don't need it for the CLI (other than for silencing scanners).

Let me put this in draft, but we can decide what we want to do (mostly trying to keep the diff for the .1 release small / limited to what we really need / want)

@thaJeztah thaJeztah marked this pull request as draft February 25, 2025 13:52
@thaJeztah thaJeztah added this to the 28.1.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/go-sdk Changes affecting the Go SDK impact/changelog impact/go-sdk Noteworthy (compatibility changes) in the Go SDK status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants