Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: remove "experimental" checks, as they may be redundant #5140

Open
thaJeztah opened this issue Jun 11, 2024 · 2 comments · May be fixed by #5863
Open

CI: remove "experimental" checks, as they may be redundant #5140

thaJeztah opened this issue Jun 11, 2024 · 2 comments · May be fixed by #5863
Labels
area/testing kind/enhancement

Comments

@thaJeztah
Copy link
Member

Description

While working on #5139, I noticed that CI was green even if we didn't enable experimental on the daemon.

I was curious how the experimental and non-experimental e2e tests differed, and after a cursory glance, it may be only for a single test;

cli/e2e/image/build_test.go

Line 128 in 591bd17

environment.SkipIfNotExperimentalDaemon(t)

If that's correct, then it would mean we run all e2e tests twice, but only for a single test; we can cut the number of checks in half if we don't do so;

  • Always enable experimental on the daemon (we already do so!)
  • Run the tests and let the "experimental" one be skipped
  • Rejoice!
@thaJeztah thaJeztah mentioned this issue Jun 11, 2024
Merged
@Benehiko
Copy link
Member

  • Always enable experimental on the daemon (we already do so!)
  • Run the tests and let the "experimental" one be skipped
  • Rejoice!

@thaJeztah So if we are always running an experimental daemon, do you mean to say we should disable the non-experimental run?

@thaJeztah
Copy link
Member Author

Yeah, if it's indeed only that one tests I saw being different, we could run all e2e tests with "experimental" enabled (unconditionally), and just have a single e2e suite (that runs both "experimental" and "non-experimental" tests)

@Benehiko Benehiko linked a pull request Feb 24, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workflow/e2e: only run experimental daemon Benehiko/docker-cli
2 participants
@thaJeztah @Benehiko