[Bug]: Strange condition on UserInfo

[valadas]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

This condition will always be false after refactoring in #5971

Steps to reproduce?

This condition should never be entered as it will always be false, this is just a note to remove this block at some point in time.

Current Behavior

No response

Expected Behavior

No response

Relevant log output

No response

Anything else?

No response

Affected Versions

9.13.3 (alpha)

What browsers are you seeing the problem on?

Chrome

Code of Conduct

• I agree to follow this project's Code of Conduct

[valadas]

No, basically this is the user profile module, it used to be used by both users and admins but now admins have a new experience in the persona bar. So this code was all refactored to no longer user User and only UserInfo and that block of code is basically to remove, it is right now always false and this is just a reminder for code cleanup at some point.

[Mostafa-Moafi]

No, basically this is the user profile module, it used to be used by both users and admins but now admins have a new experience in the persona bar. So this code was all refactored to no longer user User and only UserInfo and that block of code is basically to remove, it is right now always false and this is just a reminder for code cleanup at some point.

Do you just have to remove the condition?

[valadas]

@Mostafa-Moafi basically the whole if block can go away as one will never be both a superuser and not a superuser, so that code will never ever run anyway.