[FEAT] Skeleton 컴포넌트, 스토리북 #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
close #281
✨ 작업 내용
Skeleton컴포넌트, 스토리북 구현했습니다.Skeleton의 layout을text와box로 구분하고, 의견 주셨던width와heigth을 props로 받도록 구현했습니다.Skeleton에도 동일한 padding을 적용하는 것이 적합하다고 판단했습니다. 이때,Skeleton에 별도의 padding props를 추가하지 않고,FlexBox의 padding 값을 활용하여 구현했습니다!Suspense뺐습니다!🙏 기타 참고 사항