Skip to content

Commit bf3e6cf

Browse files
author
Antonio
committed
Using .replace
1 parent eeaab93 commit bf3e6cf

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/python/WMCore/WMSpec/StdSpecs/Repack.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,9 @@ def buildWorkload(self):
5050

5151
# complete output configuration
5252
for output in self.outputs:
53-
# if its a rawSkim dataset, moduleLabel is different
54-
if not 'moduleLabel' in output:
55-
output['moduleLabel'] = "write_%s_%s" % (output['primaryDataset'],
56-
output['dataTier'])
53+
moduleLabel = "write_%s_%s" % (output['primaryDataset'],
54+
output['dataTier'])
55+
output['moduleLabel'] = moduleLabel.replace("-", "_") # For T0 Raw Skims, PDs will contain a "-", so here we replace for "_" for the moduleLabel
5756

5857
# finalize splitting parameters
5958
mySplitArgs = self.repackSplitArgs.copy()

src/python/WMCore/WMSpec/StdSpecs/StdBase.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,8 @@ def determineOutputModules(self, scenarioFunc=None, scenarioArgs=None,
223223
outputModules[moduleLabel] = {'dataTier': output['dataTier']}
224224
if 'primaryDataset' in output:
225225
outputModules[moduleLabel]['primaryDataset'] = output['primaryDataset']
226+
if 'rawSkim' in output:
227+
outputModules[moduleLabel]['rawSkim'] = output['rawSkim']
226228
if 'filterName' in output:
227229
outputModules[moduleLabel]['filterName'] = output['filterName']
228230

@@ -467,6 +469,7 @@ def setupProcessingTask(self, procTask, taskType, inputDataset=None, inputStep=N
467469
self.inputPrimaryDataset),
468470
configOutput[outputModuleName]['dataTier'],
469471
configOutput[outputModuleName].get('filterName', None),
472+
configOutput[outputModuleName].get('rawSkim', None),
470473
forceMerged=forceMerged, forceUnmerged=forceUnmerged, taskConf=taskConf)
471474
outputModules[outputModuleName] = outputModule
472475

@@ -480,7 +483,7 @@ def setupProcessingTask(self, procTask, taskType, inputDataset=None, inputStep=N
480483
del output['primaryDataset']
481484
if 'primaryDataset' in scenarioArgs:
482485
del scenarioArgs['primaryDataset']
483-
486+
logging.info("+++ scenarioArgs = {}".format(scenarioArgs))
484487
procTaskCmsswHelper.setDataProcessingConfig(scenarioName, scenarioFunc,
485488
**scenarioArgs)
486489
# only in the very end, in order to get it in for the children tasks as well
@@ -507,6 +510,7 @@ def _getDictionaryParams(self, prop, key, default=None):
507510

508511
def addOutputModule(self, parentTask, outputModuleName,
509512
primaryDataset, dataTier, filterName,
513+
rawSkim=None,
510514
stepName="cmsRun1", forceMerged=False,
511515
forceUnmerged=False, taskConf=None):
512516
"""
@@ -583,14 +587,16 @@ def addOutputModule(self, parentTask, outputModuleName,
583587
processedDataset=processedDataset,
584588
dataTier=dataTier,
585589
filterName=filterName,
590+
rawSkim=rawSkim,
586591
lfnBase=unmergedLFN,
587592
mergedLFNBase=mergedLFN,
588593
transient=isTransient)
589594

590595
return {"primaryDataset": primaryDataset,
591596
"dataTier": dataTier,
592597
"processedDataset": processedDataset,
593-
"filterName": filterName}
598+
"filterName": filterName,
599+
"rawSkim": rawSkim}
594600

595601
def addLogCollectTask(self, parentTask, taskName="LogCollect", filesPerJob=500,
596602
cmsswVersion=None, scramArch=None):

0 commit comments

Comments
 (0)