Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fig-alt support to rgl graphs #341

Open
dmurdoch opened this issue Mar 15, 2023 · 2 comments · Fixed by #342
Open

Add fig-alt support to rgl graphs #341

dmurdoch opened this issue Mar 15, 2023 · 2 comments · Fixed by #342

Comments

@dmurdoch
Copy link
Owner

#336 correctly noted that the vignette had base graphics without alt text. However, all rgl plots also lack alt text, because the widget doesn't support it. That should be added.

It won't be trivial, because rgl figures are normally canvas elements, not img elements, and canvas doesn't support alt text. But there are workarounds, e.g. https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_usage .

@dmurdoch

This comment was marked as outdated.

@dmurdoch
Copy link
Owner Author

I believe this is all done now, subject to knitr accepting my pull request: yihui/knitr#2243 . I'll leave the issue open until that is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant