-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createPacket not working on 1.20.4 (and again on 1.20.5/6) ! #2669
Comments
I can also reproduce this issue on Spigot-1.20.4 ( |
Was able to reproduce this. Looking into it further |
Give the latest build a try: https://ci.dmulloy2.net/job/ProtocolLib/lastBuild/ Shows as failing since not all the tests are passing yet. But it should fix the packet creation issue |
Looks works for me. |
Seems to be fixed, thanks! ;) |
Hi again, It was OK with build #675. This seems to be a little random and not every error happes with every serverstart. |
OK, Build 677 works again ;) |
New problem mention in #2856 |
This seems to be broken again (build #686 and MC 1.20.5): rest is the same as before... |
How can you even use 1.20.5? it doesn't work at all |
Spigot 'works' ... paper does not. |
Having the same issue here, can load protocollib with obfuscated version of 1.20.6 as per issue #2900 but still getting the issue with: |
Hi again, new build 689 now works under Paper again, but still throws errors on packet creation: e.g. I have two lines of code like this:
And Spigot still has this error:
With Paper the crash is at 2nd line like this ('EnumChatVisibility' has to be 'ChatVisibility' in unobfuscated Paper ):
Strangely Paper does not crash at first line... |
I can reproduce this issue with Spigot 1.20.6:
PacketContainer fakeItemPacket = manager.getProtocolManager().createPacket(PacketType.Play.Server.SPAWN_ENTITY); |
Same issue |
Yeah, same here, tested with both obf and deobf version of paper from gradle build. |
More info here: #2917 |
Still exists on Paper-77 (1.20.6) with ProtocolLib v5.2.1-SNAPSHOT-689 |
Are there any temporary work arounds for now? |
@seraph-prisons |
So, you know what to change to fix this bug? |
Is this fixed? |
No, it's not ! @dmulloy2 : any progress? |
@dmulloy2 Build 699: still not fixed! Spigot throws exact same exception when trying getProtocolManager().createPacket(PacketType.Play.Server.PLAYER_INFO); Paper does not (with PLAYER_INFO), but throws same exception with getProtocolManager().createPacket(PacketType.Play.Server.SPAWN_ENTITY); |
In my case...
in my code. 11: public class WrapperPlayServerPlayerInfo extends AbstractPacket {
12: public static final PacketType TYPE = PacketType.Play.Server.PLAYER_INFO;
13:
14: public WrapperPlayServerPlayerInfo() {
15: super(new PacketContainer(TYPE), TYPE); // <--- NPE on Paper 1.20.6
16: handle.getModifier().writeDefaults();
17: } |
Fixed in
Thank you! |
You should be able to create all but MAP_CHUNK, SCOREBOARD_OBJECTIVE, and ENTITY_SOUND. Those 3 require some special handling that still needs to be worked out |
Looks good again ;) Thanks! |
com.comphenix.protocol.ProtocolLibrary.getProtocolManager().createPacket(com.comphenix.protocol.PacketType.Play.Server.SPAWN_ENTITY)
throws the following error:
[Server thread/WARN]: java.lang.NullPointerException: Unable to create packet instance for class class net.minecraft.network.protocol.game.PacketPlayOutSpawnEntity
[Server thread/WARN]: at java.base/java.util.Objects.requireNonNull(Unknown Source)
[Server thread/WARN]: at com.comphenix.protocol.injector.StructureCache.lambda$newPacket$2(StructureCache.java:99)
[Server thread/WARN]: at com.comphenix.protocol.injector.StructureCache.newPacket(StructureCache.java:103)
[Server thread/WARN]: at com.comphenix.protocol.injector.StructureCache.newPacket(StructureCache.java:113)
[Server thread/WARN]: at com.comphenix.protocol.events.PacketContainer.(PacketContainer.java:117)
[Server thread/WARN]: at com.comphenix.protocol.injector.PacketFilterManager.createPacket(PacketFilterManager.java:389)
[Server thread/WARN]: at com.comphenix.protocol.injector.PacketFilterManager.createPacket(PacketFilterManager.java:384)
Version Info
Minecraft: Spigot 1.20.4 (8.12.2023)
ProtocolLib build #673
The text was updated successfully, but these errors were encountered: