Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in the 0068-feel-equality test? #682

Open
jvinis opened this issue Nov 14, 2024 · 4 comments
Open

Issue in the 0068-feel-equality test? #682

jvinis opened this issue Nov 14, 2024 · 4 comments

Comments

@jvinis
Copy link

jvinis commented Nov 14, 2024

The description declares "...expects result: 'true (boolean)'",
but the allowed answer is false! false (boolean)

Tests FEEL expression: 'date and time("2018-10-08T00:00:00+01:00") = date and time("2018-10-08T00:00:00@Europe/Paris")' and expects result: 'true (boolean)' Result of FEEL expression 'date and time("2018-10-08T00:00:00+01:00") = date and time("2018-10-08T00:00:00@Europe/Paris")'? false (boolean) date and time("2018-10-08T00:00:00+01:00") = date and time("2018-10-08T00:00:00@Europe/Paris")
@jvinis jvinis changed the title 0068-feel-equality test issue? Issue in the 0068-feel-equality test? Nov 14, 2024
@opatrascoiu
Copy link
Contributor

opatrascoiu commented Nov 14, 2024

@jvinis Thank you for raising this. I believe you are referring to the test for datetime_008. The comments in the DMN and TCK files are out of synch with the expected value in the TCK file. We need a PR to change the comments. Would you be able to do that?

@jvinis
Copy link
Author

jvinis commented Nov 14, 2024

The problem is at the comments (0068-feel-equality.dmn) and at the expected value (0068-feel-equality-test-01.xml).
The test expect false instead of true.

<testCase id="datetime_008"> <description>same datetimes, one with offset and the other with zone are equal</description> <resultNode name="datetime_008" type="decision"> <expected> <value xsi:type="xsd:boolean">false</value> </expected> </resultNode> </testCase>

@opatrascoiu
Copy link
Contributor

@jvinis Yes, you are right, the boolean value specified in the comments (both DMN and TCK file) do not match the expected value (true in comments and false in expected value tag).

However, the test is correct (actual and expected values are the same). The offset of Europe/Paris between the summer transition (end of March) and autumn transition (end of October) is +02:00 not +01:00.

I can think of two options:

change the comments or
change the test to reflect the intention stated in the TCK file by using the +02:00 offset.

@opatrascoiu
Copy link
Contributor

I created a PR here #683 to address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants