Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Write your own GNN module -- Example Code Improvement #7856

Open
Devansh-Agarwal opened this issue Jan 17, 2025 · 1 comment
Open

[Doc] Write your own GNN module -- Example Code Improvement #7856

Devansh-Agarwal opened this issue Jan 17, 2025 · 1 comment

Comments

@Devansh-Agarwal
Copy link

📚 Documentation

Tutorial part: Write your own GNN module

In the Training Loop code, there is a variable all_logits, which is present in the code and is accumulating the logits at each epoch but this accumulation is not being used anywhere.

I think it is better to remove all_logits from the code rather than keeping it as it causes confusion to the new users, it makes them think why are the logits being accumulated, when they are never being used.

If this seems an improvement, I can do a PR with the changes.

Copy link

This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant